From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id F2D671F45E for ; Wed, 12 Feb 2020 22:31:31 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729119AbgBLWbb (ORCPT ); Wed, 12 Feb 2020 17:31:31 -0500 Received: from vuizook.err.no ([178.255.151.162]:41798 "EHLO vuizook.err.no" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727564AbgBLWbb (ORCPT ); Wed, 12 Feb 2020 17:31:31 -0500 Received: from p576124-ipngn200707tokaisakaetozai.aichi.ocn.ne.jp ([122.31.139.124] helo=glandium.org) by vuizook.err.no with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j20XX-0003cn-NX; Wed, 12 Feb 2020 22:31:28 +0000 Received: from glandium by goemon.lan with local (Exim 4.92) (envelope-from ) id 1j20XS-000XQb-SH; Thu, 13 Feb 2020 07:31:22 +0900 Date: Thu, 13 Feb 2020 07:31:22 +0900 From: Mike Hommey To: Eric Sunshine Cc: Git List Subject: Re: SHA1dc on mac Message-ID: <20200212223122.svthiwmh3js7i47b@glandium.org> References: <20200212085646.hgq3nv2lf4brbb3j@glandium.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 182E 161D 1130 B9FC CD7D B167 E42A A04F A6AA 8C72 User-Agent: NeoMutt/20180716 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Feb 12, 2020 at 11:46:31AM -0500, Eric Sunshine wrote: > On Wed, Feb 12, 2020 at 3:57 AM Mike Hommey wrote: > > If I'm not mistaken in my reading of the various files involved, it > > looks like for some reason, building git on mac leads to using Apple > > Common Crypto for SHA1, rather than SHA1dc, which seems unfortunate. > > Is that really expected? > > There was a discussion on this topic a while back[1], and it does seem > that the behavior you describe is intentional[2]. That discussion predates SHA1dc, though. > > More generally, at this point, should anything > > other than SHA1dc be supported as a build option at all? > > The conclusion [2,3] was that it likely would make sense to drop > support for Apple's CommonCrypto altogether, although nobody has yet > stepped up to do the work. I wasn't explicit in my question, but I meant more broadly than Apple Common Crypto. There is still opt-in support for openssl sha1 and PPC sha1. Mike