From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 4D98B1F45E for ; Tue, 11 Feb 2020 19:48:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729856AbgBKTsH (ORCPT ); Tue, 11 Feb 2020 14:48:07 -0500 Received: from cloud.peff.net ([104.130.231.41]:57816 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1728843AbgBKTsH (ORCPT ); Tue, 11 Feb 2020 14:48:07 -0500 Received: (qmail 9375 invoked by uid 109); 11 Feb 2020 19:48:07 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 11 Feb 2020 19:48:07 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 1405 invoked by uid 111); 11 Feb 2020 19:56:58 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 11 Feb 2020 14:56:58 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 11 Feb 2020 14:48:06 -0500 From: Jeff King To: Derrick Stolee via GitGitGadget Cc: git@vger.kernel.org, me@ttaylorr.com, newren@gmail.com, Derrick Stolee Subject: Re: [PATCH 0/4] Sparse-checkout: Add subcommand and Windows paths Message-ID: <20200211194806.GB2127797@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Feb 11, 2020 at 03:02:20PM +0000, Derrick Stolee via GitGitGadget wrote: > This is based on ds/sparse-checkout-harden. > > The sparse-checkout builtin currently lets users modify their > sparse-checkout file with the all-or-nothing "set" subcommand. It may be > easier for a user to expand their sparse cone using a "git sparse-checkout > add ..." subcommand. To achieve this while reusing as much > code as possible from the "set" subcommand, the first two patches extract > methods from sparse_checkout_set(). FWIW, this makes perfect sense to me. I actually expected "set" to behave like "add" the first time I tried it out. -Peff