git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Shourya Shukla <shouryashukla.oo@gmail.com>
To: git@vger.kernel.org
Cc: Johannes.Schindelin@gmx.de, chriscool@tuxfamily.org,
	peff@peff.net, t.gummerer@gmail.com
Subject: Conversion of 'git submodule' to C: need some help
Date: Sun,  9 Feb 2020 16:43:49 +0530	[thread overview]
Message-ID: <20200209111349.20472-1-shouryashukla.oo@gmail.com> (raw)

Hello everyone,

I was trying to understand the code of 'git submodule'[1]. This is
also in reference to this conversation I had before[2].

I read the code and stumbled across a function with a 'TODO' tag[3].
Here we want to change the aforementioned function into a 'repo_submodule_init'
function I suppose.

I am facing some problems and would love some insight on them:
	
	1. What exactly are we aiming in [3]? To replace the function completely
	   or to just add some 'repo_submodule_init' functionality?

	2. Something I inferred was that functions with names of the pattern 'strbuf_git_*'
	   are trying to 'create a path'(are they physically creating the path or just
	   instructing git about them?) while functions of the pattern 'git_*' are trying
	   to check some conditions denoted by their function names(for instance
	   'git_config_rename_section_in_file')? Is this inference correct to some extent?

	3. How does one check which all parts of a command have been completed? Is it checked
	   by looking at the file history or by comparing with the shell script of the command
	   or are there any other means?
	
	4. Is it fine if I am not able to understand the purpose of certain functions right now(such as
	   'add_submodule_odb')? I am able to get a rough idea of what the functions are doing but I am
	   not able to decode certain functions line-by-line.

Currently, I am studying in depth about 'git objects' and the submodule command on the git Documentation.
What else do would you advise me to strengthen my understanding of the code and git in general?

Regards,
Shourya Shukla

[1]: https://github.com/periperidip/git/blob/v2.25.0/submodule.c
[2]: https://lore.kernel.org/git/20200201173841.13760-1-shouryashukla.oo@gmail.com/
[3]: https://github.com/periperidip/git/blob/v2.25.0/submodule.c#L168


             reply	other threads:[~2020-02-09 11:13 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-09 11:13 Shourya Shukla [this message]
2020-02-13 13:33 ` Conversion of 'git submodule' to C: need some help Johannes Schindelin
  -- strict thread matches above, loose matches on Subject: below --
2020-02-09 15:00 Abhishek Kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200209111349.20472-1-shouryashukla.oo@gmail.com \
    --to=shouryashukla.oo@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    --cc=t.gummerer@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).