From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI,RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id BD93B1F5A2 for ; Fri, 7 Feb 2020 11:02:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726867AbgBGLCW (ORCPT ); Fri, 7 Feb 2020 06:02:22 -0500 Received: from fllv0015.ext.ti.com ([198.47.19.141]:35552 "EHLO fllv0015.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726674AbgBGLCW (ORCPT ); Fri, 7 Feb 2020 06:02:22 -0500 Received: from lelv0266.itg.ti.com ([10.180.67.225]) by fllv0015.ext.ti.com (8.15.2/8.15.2) with ESMTP id 017B2IT5098896; Fri, 7 Feb 2020 05:02:18 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1581073338; bh=yiuPazv0EfxFbK37Uy/s7iFwwke4lCeGt9p1izx2l/M=; h=Date:From:To:CC:Subject:References:In-Reply-To; b=fZjkONWRp2h40aCFhLpkBqhgzv81wIVHGteEtjMo784NZm9FdFyBXRy9Stb+kjxft bUbQMMvb5doFTmTnhwP0CCRsI97kvnMQrqM0l183FygYdRneGWbAcrvgZJxZ2O259f adAYKfmTWhUfjVtvLpqttmvydcLcU/9G4TEVtwSM= Received: from DFLE107.ent.ti.com (dfle107.ent.ti.com [10.64.6.28]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 017B2IGk095509 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 7 Feb 2020 05:02:18 -0600 Received: from DFLE108.ent.ti.com (10.64.6.29) by DFLE107.ent.ti.com (10.64.6.28) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3; Fri, 7 Feb 2020 05:02:18 -0600 Received: from fllv0040.itg.ti.com (10.64.41.20) by DFLE108.ent.ti.com (10.64.6.29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1847.3 via Frontend Transport; Fri, 7 Feb 2020 05:02:18 -0600 Received: from localhost (ileax41-snat.itg.ti.com [10.172.224.153]) by fllv0040.itg.ti.com (8.15.2/8.15.2) with ESMTP id 017B2Hn1116116; Fri, 7 Feb 2020 05:02:18 -0600 Date: Fri, 7 Feb 2020 16:32:16 +0530 From: Pratyush Yadav To: Junio C Hamano CC: =?iso-8859-1?Q?Ren=E9?= Scharfe , "Michael S. Tsirkin" , Subject: Re: bug? illegal text in commit log Message-ID: <20200207110216.ppf5aksfkam54bip@ti.com> References: <20200204010524-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20171215 X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 06/02/20 08:45AM, Junio C Hamano wrote: > René Scharfe writes: > > > Like a Lines: header specifying the number of lines in the commit message? > > The only part of the workflow that can count the number reliably is > format-patch. But the output of format-patch is designed to be > edited further, and expecting users to adjust the number when they > make such an edit is a bit too much. I haven't thought this through, but I'll throw the idea out anyway: How about counting lines in the diff (the one generated by format-patch, not the one in the commit message) instead of lines in the commit message? This way, the bottom n lines in the mail (barring the signature) are the diff contents. I personally have often edited the commit message and added comments below the '---' line in the patches output by format-patch, but I rarely ever manually edit the diff. It is just really easy to corrupt the patch when you manually edit it. -- Regards, Pratyush Yadav