From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 175F71F466 for ; Sat, 1 Feb 2020 11:02:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726336AbgBALCF (ORCPT ); Sat, 1 Feb 2020 06:02:05 -0500 Received: from cloud.peff.net ([104.130.231.41]:50290 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726175AbgBALCF (ORCPT ); Sat, 1 Feb 2020 06:02:05 -0500 Received: (qmail 21021 invoked by uid 109); 1 Feb 2020 11:02:04 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Sat, 01 Feb 2020 11:02:04 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 7997 invoked by uid 111); 1 Feb 2020 11:09:58 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Sat, 01 Feb 2020 06:09:58 -0500 Authentication-Results: peff.net; auth=none Date: Sat, 1 Feb 2020 06:02:03 -0500 From: Jeff King To: Johannes Schindelin Cc: Mike McGranahan , git@vger.kernel.org Subject: Re: Patch text in git-add patch mode lacks whitespace highlighting Message-ID: <20200201110203.GA1864964@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Jan 31, 2020 at 01:37:44PM +0100, Johannes Schindelin wrote: > If my reading is correct, and we want `git diff-files --color` to respect > the `diff.wsErrorHighlight` setting, then this patch fixes that: > [...] > The bigger question is whether other core developers agree with this? And > what other `diff.*` settings should be respected by `git diff-files` (and > of course, `git diff-index`)? I think you can take my posting of an identical patch elsewhere in the thread as a "yes". :) -Peff