From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 70EAB1F466 for ; Thu, 30 Jan 2020 07:30:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726704AbgA3H37 (ORCPT ); Thu, 30 Jan 2020 02:29:59 -0500 Received: from cloud.peff.net ([104.130.231.41]:48186 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1726185AbgA3H37 (ORCPT ); Thu, 30 Jan 2020 02:29:59 -0500 Received: (qmail 21746 invoked by uid 109); 30 Jan 2020 07:29:58 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Thu, 30 Jan 2020 07:29:58 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 21484 invoked by uid 111); 30 Jan 2020 07:37:40 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Thu, 30 Jan 2020 02:37:40 -0500 Authentication-Results: peff.net; auth=none Date: Thu, 30 Jan 2020 02:29:57 -0500 From: Jeff King To: Derrick Stolee Cc: Derrick Stolee via GitGitGadget , git@vger.kernel.org, me@ttaylorr.com, newren@gmail.com, Derrick Stolee Subject: Re: [PATCH v3 10/12] sparse-checkout: write escaped patterns in cone mode Message-ID: <20200130072957.GE2189233@coredump.intra.peff.net> References: <20200129101713.GB4218@coredump.intra.peff.net> <20200129103352.GD4218@coredump.intra.peff.net> <7a85cded-eccf-9f33-4056-08b2923b2861@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <7a85cded-eccf-9f33-4056-08b2923b2861@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Wed, Jan 29, 2020 at 09:16:11AM -0500, Derrick Stolee wrote: > I've applied the smaller comments and am now investigating the right > thing to do with other is_glob_special() characters. There is a small > chance that I can replace any "c == '*' || c == '\'" with is_glob_special(), > but we shall see. At the very least, I'll need to expand my tests. Yeah, that's all I'd expect to need. You mentioned earlier about how ls-tree would output them, but I don't think it would matter. Now that you're using unquote_c_style(), you'll get the literal filenames no matter which way ls-tree decides to quote them (and I don't think it would quote '?', just as it wouldn't '*', because those are not syntactically significant in its output). -Peff