From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 68DFF1F4B9 for ; Sat, 25 Jan 2020 17:01:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726428AbgAYRBe (ORCPT ); Sat, 25 Jan 2020 12:01:34 -0500 Received: from relay2-d.mail.gandi.net ([217.70.183.194]:62615 "EHLO relay2-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725843AbgAYRBe (ORCPT ); Sat, 25 Jan 2020 12:01:34 -0500 X-Originating-IP: 112.133.229.71 Received: from localhost (unknown [112.133.229.71]) (Authenticated sender: me@yadavpratyush.com) by relay2-d.mail.gandi.net (Postfix) with ESMTPSA id 1C8A540004; Sat, 25 Jan 2020 17:01:31 +0000 (UTC) Date: Sat, 25 Jan 2020 22:31:28 +0530 From: Pratyush Yadav To: Christian Stimming via GitGitGadget Cc: git@vger.kernel.org, Christian Stimming Subject: Re: [PATCH 3/3] git-gui: completed german translation Message-ID: <20200125170128.td2x66xzucqcdfno@yadavpratyush.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Hi, > Subject: Re: [PATCH 3/3] git-gui: completed german translation Well, since I don't have much to say about the patch contents, I'll just comment on the commit message. "completed german translation" seems to suggest it was in some way incomplete before. My impression from reading the patch is that it is more glossary/word changes. Maybe change the subject to reflect that? On 24/01/20 10:33PM, Christian Stimming via GitGitGadget wrote: > From: Christian Stimming > > More glossary changed, mostly adapted to git-core German glossary at > https://github.com/ruester/git-po-de/wiki/Translation-Guidelines > and translation changed accordingly. One notable change in translation > is branch -> Branch. Overall increased consistency. Same comment as the last patch: along with explaining _what_ the commit does, also explain _why_ the commit does it. Thanks for the patches. Will merge them once you send in a re-roll with the updated commit subjects and messages. PS: It would be nice if we can get an ACK from a German speaker. > Signed-off-by: Christian Stimming -- Regards, Pratyush Yadav