From: Pratyush Yadav <me@yadavpratyush.com>
To: Christian Stimming via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Christian Stimming <christian@cstimming.de>
Subject: Re: [PATCH 3/3] git-gui: completed german translation
Date: Sat, 25 Jan 2020 22:31:28 +0530 [thread overview]
Message-ID: <20200125170128.td2x66xzucqcdfno@yadavpratyush.com> (raw)
In-Reply-To: <c91a84b0eddc22b021afe32ca4cb54c70d609c09.1579905218.git.gitgitgadget@gmail.com>
Hi,
> Subject: Re: [PATCH 3/3] git-gui: completed german translation
Well, since I don't have much to say about the patch contents, I'll just
comment on the commit message.
"completed german translation" seems to suggest it was in some way
incomplete before. My impression from reading the patch is that it is
more glossary/word changes. Maybe change the subject to reflect that?
On 24/01/20 10:33PM, Christian Stimming via GitGitGadget wrote:
> From: Christian Stimming <christian@cstimming.de>
>
> More glossary changed, mostly adapted to git-core German glossary at
> https://github.com/ruester/git-po-de/wiki/Translation-Guidelines
> and translation changed accordingly. One notable change in translation
> is branch -> Branch. Overall increased consistency.
Same comment as the last patch: along with explaining _what_ the commit
does, also explain _why_ the commit does it.
Thanks for the patches. Will merge them once you send in a re-roll with
the updated commit subjects and messages.
PS: It would be nice if we can get an ACK from a German speaker.
> Signed-off-by: Christian Stimming <christian@cstimming.de>
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2020-01-25 17:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-24 22:33 [PATCH 0/3] git gui: improve German translation Christian Stimming via GitGitGadget
2020-01-24 22:33 ` [PATCH 1/3] git-gui: update german translation to most recently created pot templates Christian Stimming via GitGitGadget
2020-01-24 22:33 ` [PATCH 2/3] git-gui: update german translation Christian Stimming via GitGitGadget
2020-01-25 16:56 ` Pratyush Yadav
2020-01-26 15:52 ` Christian Stimming
2020-01-27 19:02 ` Junio C Hamano
2020-01-28 18:40 ` Pratyush Yadav
2020-01-24 22:33 ` [PATCH 3/3] git-gui: completed " Christian Stimming via GitGitGadget
2020-01-25 17:01 ` Pratyush Yadav [this message]
2020-02-09 22:00 ` [PATCH v2 0/3] git gui: improve German translation Christian Stimming via GitGitGadget
2020-02-09 22:00 ` [PATCH v2 1/3] git-gui: update pot template and German translation to current source code Christian Stimming via GitGitGadget
2020-02-09 22:00 ` [PATCH v2 2/3] git-gui: extend translation glossary template with more terms Christian Stimming via GitGitGadget
2020-02-09 22:00 ` [PATCH v2 3/3] git-gui: update German translation Christian Stimming via GitGitGadget
2020-02-17 15:50 ` [PATCH v2 0/3] git gui: improve " Pratyush Yadav
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200125170128.td2x66xzucqcdfno@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=christian@cstimming.de \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).