git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Pratyush Yadav <me@yadavpratyush.com>
To: Christian Stimming via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org, Christian Stimming <christian@cstimming.de>
Subject: Re: [PATCH 2/3] git-gui: update german translation
Date: Sat, 25 Jan 2020 22:26:29 +0530	[thread overview]
Message-ID: <20200125165629.55hsywaqojsdpqik@yadavpratyush.com> (raw)
In-Reply-To: <85842282221465469872ed1d5be63dfb2399fb43.1579905218.git.gitgitgadget@gmail.com>

Hi Christian,

Thanks for the patches. I don't have much to say about this patch other 
than the commit message since I don't speak German.

> Subject: Re: [PATCH 2/3] git-gui: update german translation

Nitpick: capitalise "german". So, s/german/German/

On 24/01/20 10:33PM, Christian Stimming via GitGitGadget wrote:
> From: Christian Stimming <christian@cstimming.de>
> 
> Switch several terms from uncommon translations back to english
> vocabulary, most prominently commit (noun, verb) and repository. Adapt
> glossary and translation accordingly.

Can you also explain _why_ these uncommon translations are changed to 
English vocabulary? My guess is that the translated versions are too 
awkward and don't express the meaning very well, and terms like "commit" 
and "repository" are more suitable even when German is being used. An 
explanation like this would help explain the need for this patch much 
better.

Everything else looks fine.

PS: It would be nice if we can get an ACK from a German speaker.
 
> Signed-off-by: Christian Stimming <christian@cstimming.de>

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2020-01-25 16:56 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-24 22:33 [PATCH 0/3] git gui: improve German translation Christian Stimming via GitGitGadget
2020-01-24 22:33 ` [PATCH 1/3] git-gui: update german translation to most recently created pot templates Christian Stimming via GitGitGadget
2020-01-24 22:33 ` [PATCH 2/3] git-gui: update german translation Christian Stimming via GitGitGadget
2020-01-25 16:56   ` Pratyush Yadav [this message]
2020-01-26 15:52     ` Christian Stimming
2020-01-27 19:02       ` Junio C Hamano
2020-01-28 18:40       ` Pratyush Yadav
2020-01-24 22:33 ` [PATCH 3/3] git-gui: completed " Christian Stimming via GitGitGadget
2020-01-25 17:01   ` Pratyush Yadav
2020-02-09 22:00 ` [PATCH v2 0/3] git gui: improve German translation Christian Stimming via GitGitGadget
2020-02-09 22:00   ` [PATCH v2 1/3] git-gui: update pot template and German translation to current source code Christian Stimming via GitGitGadget
2020-02-09 22:00   ` [PATCH v2 2/3] git-gui: extend translation glossary template with more terms Christian Stimming via GitGitGadget
2020-02-09 22:00   ` [PATCH v2 3/3] git-gui: update German translation Christian Stimming via GitGitGadget
2020-02-17 15:50   ` [PATCH v2 0/3] git gui: improve " Pratyush Yadav

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200125165629.55hsywaqojsdpqik@yadavpratyush.com \
    --to=me@yadavpratyush.com \
    --cc=christian@cstimming.de \
    --cc=git@vger.kernel.org \
    --cc=gitgitgadget@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).