From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: ch <cr@onlinehome.de>,
Martin von Zweigbergk <martinvonz@gmail.com>,
Paul Mackerras <paulus@ozlabs.org>
Cc: git@vger.kernel.org
Subject: Re: [REGRESSION] gitk can't be run from non-worktree folders
Date: Thu, 23 Jan 2020 17:31:51 +0100 [thread overview]
Message-ID: <20200123163151.GC6837@szeder.dev> (raw)
In-Reply-To: <4e2e5829-b9a7-b9b4-5605-ac28e8dbc45a@onlinehome.de>
On Thu, Jan 23, 2020 at 05:04:09PM +0100, ch wrote:
> I recently updated my Git installation from 2.24.1.windows.2 to
> 2.25.0.windows.1 and from the looks of it the included version of gitk does not
> support being run from non-worktree folders of a repository anymore (like the
> .git folder for example).
>
> Here's a small reproduction recipe:
>
> $ git init repro
> $ cd repro
> $ git commit -m test --allow-empty
> $ cd .git
> $ gitk --all &
>
> gitk terminates with the message:
>
> fatal: this operation must be run in a work tree
> while executing
> "exec git rev-parse --show-toplevel"
> invoked from within
> "set worktree [exec git rev-parse --show-toplevel]"
> (file "C:/Program Files/Git/mingw64/bin/gitk" line 12634)
I've stumbled upon the same issue when I tried to run 'gitk' in a bare
repository a while ago, but it refused to run with the same error
message.
Are you sure it's a recent regression? I have no experience with
'gitk' in Git for Windows, but on Linux this has been broken for quite
some time, namely since 784b7e2f25 (gitk: Fix "External diff" with
separate work tree, 2011-04-04) in the v1.7 era. FWIW, reverting that
commit on top of v2.25.0 makes 'gitk' work again in bare repositories.
next prev parent reply other threads:[~2020-01-23 16:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-23 16:04 [REGRESSION] gitk can't be run from non-worktree folders ch
2020-01-23 16:31 ` SZEDER Gábor [this message]
2020-01-23 16:36 ` Eric Sunshine
2020-01-23 17:04 ` SZEDER Gábor
2020-01-23 17:46 ` SZEDER Gábor
2020-01-23 19:02 ` Junio C Hamano
2020-01-23 19:20 ` [PATCH] gitk: to run in a bare repository (was: gitk can't be run from non-worktree folders) Junio C Hamano
2020-01-23 19:26 ` Eric Sunshine
2020-01-23 19:27 ` Jeff King
2020-03-30 15:20 ` ch
2020-10-11 5:08 ` Eric Sunshine
2020-10-13 14:25 ` [PATCH] gitk: to run in a bare repository ch
2020-10-13 15:31 ` Pratyush Yadav
2020-04-02 13:40 ` [REGRESSION] gitk can't be run from non-worktree folders ch
2020-04-02 17:47 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200123163151.GC6837@szeder.dev \
--to=szeder.dev@gmail.com \
--cc=cr@onlinehome.de \
--cc=git@vger.kernel.org \
--cc=martinvonz@gmail.com \
--cc=paulus@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).