From: Jeff King <peff@peff.net>
To: Eyal Soha <shawarmakarma@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] color.c: Support bright aixterm colors
Date: Wed, 15 Jan 2020 17:42:44 -0500 [thread overview]
Message-ID: <20200115224244.GB4117117@coredump.intra.peff.net> (raw)
In-Reply-To: <20200110150547.221314-2-shawarmakarma@gmail.com>
On Fri, Jan 10, 2020 at 10:05:46AM -0500, Eyal Soha wrote:
> These colors are the bright variants of the 3-bit colors.
It might be worth noting a few things we discussed. In particular:
These can generally already be accessed as colors 8-15 of 256-color
mode. But some terminals support these 16-color versions without
supporting 256-color mode. And they're fewer bytes, which can make the
output slightly more efficient.
> color.c | 30 +++++++++++++++++++++++-------
> t/t4026-color.sh | 8 ++++++++
> 2 files changed, 31 insertions(+), 7 deletions(-)
I think we'd need a documentation change, too. These are discussed in
Documentation/config.txt (search for the "color::" heading).
> + int color_offset = COLOR_FOREGROUND_ANSI;
> + if (strncasecmp(name, "bright", 6) == 0) {
> + color_offset = COLOR_FOREGROUND_BRIGHT_ANSI;
> + name += 6;
> + len -= 6;
> + }
This drops the "+" version. I think we _could_ do both, but just having
"bright" is probably fine.
Having to repeat "6" isn't ideal, but we sadly don't have a
case-insensitive version of skip_prefix(). We could do:
static const char bright[] = "bright";
...
if (istarts_with(name, bright)) {
color_offset = COLOR_FOREGROUND_BRIGHT_ANSI;
name += strlen(bright);
len -= strlen(bright);
}
but I'm not sure if it's worth it.
> + for (int i = 0; i < ARRAY_SIZE(color_names); i++) {
> + if (match_word(name, len, color_names[i])) {
> + out->type = COLOR_ANSI;
> + out->value = i + color_offset;
> + return 1;
> + }
> + }
> + return 0;
> +}
The 0/1 return here is unusual for our codebase. We'd usually return "0"
for success and "-1" for failure.
Otherwise, the patch looks good.
-Peff
next prev parent reply other threads:[~2020-01-15 22:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CANsz78+ugmd62F4Qk+VT7Pi=ZPtMSkZjXOwLNRCFhoS9jrOkeQ@mail.gmail.com>
[not found] ` <CANsz78K-BiswWPdhd_N25NuApcv7zSb2cw2Y9DSinkpNpuogYw@mail.gmail.com>
2020-01-07 15:36 ` Fwd: Add support for axiterm colors in parse_color Eyal Soha
2020-01-08 9:52 ` Jeff King
2020-01-10 0:20 ` Eyal Soha
2020-01-10 11:15 ` Jeff King
2020-01-10 15:02 ` Eyal Soha
2020-01-15 15:32 ` Eyal Soha
2020-01-10 15:05 ` [PATCH 1/3] color.c: Refactor color_output to use enums Eyal Soha
2020-01-10 15:05 ` [PATCH 2/3] color.c: Support bright aixterm colors Eyal Soha
2020-01-15 22:42 ` Jeff King [this message]
2020-01-10 15:05 ` [PATCH 3/3] color.c: Alias RGB colors 8-15 to " Eyal Soha
2020-01-15 22:45 ` Jeff King
2020-01-15 22:33 ` [PATCH 1/3] color.c: Refactor color_output to use enums Jeff King
2020-01-16 18:01 ` Junio C Hamano
2020-01-16 18:23 ` Jeff King
2020-01-16 19:25 ` Eyal Soha
2020-01-18 14:53 ` Eyal Soha
2020-01-18 14:53 ` [PATCH 2/3] color.c: Support bright aixterm colors Eyal Soha
2020-01-18 18:47 ` Junio C Hamano
2020-01-21 16:52 ` Eyal Soha
2020-01-21 16:56 ` [PATCH 1/3] color.c: refactor color_output arguments Eyal Soha
2020-01-21 16:56 ` [PATCH 2/3] color.c: support bright aixterm colors Eyal Soha
2020-01-23 22:54 ` Junio C Hamano
2020-01-21 16:56 ` [PATCH 3/3] color.c: alias RGB colors 8-15 to " Eyal Soha
2020-01-23 22:50 ` [PATCH 1/3] color.c: refactor color_output arguments Junio C Hamano
2020-02-11 19:36 ` [PATCH v3 0/3] es/bright-colors (hopefully final) reroll Junio C Hamano
2020-02-11 19:36 ` [PATCH v3 1/3] color.c: refactor color_output arguments Junio C Hamano
2020-02-11 19:46 ` Jeff King
2020-02-11 23:01 ` Eyal Soha
2020-02-11 23:06 ` Junio C Hamano
2020-02-11 19:36 ` [PATCH v3 2/3] color.c: support bright aixterm colors Junio C Hamano
2020-02-11 19:36 ` [PATCH v3 3/3] color.c: alias RGB colors 8-15 to " Junio C Hamano
2020-01-21 17:37 ` [PATCH 2/3] color.c: Support bright " Junio C Hamano
2020-01-18 14:53 ` [PATCH 3/3] color.c: Alias RGB colors 8-15 to " Eyal Soha
2020-01-18 18:34 ` Junio C Hamano
2020-01-18 17:51 ` [PATCH 1/3] color.c: Refactor color_output to use enums Junio C Hamano
2020-01-21 16:37 ` Eyal Soha
2020-01-21 17:49 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200115224244.GB4117117@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=shawarmakarma@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).