From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 3C7AB1F466 for ; Tue, 14 Jan 2020 22:03:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728731AbgANWD6 (ORCPT ); Tue, 14 Jan 2020 17:03:58 -0500 Received: from cloud.peff.net ([104.130.231.41]:36630 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727289AbgANWD6 (ORCPT ); Tue, 14 Jan 2020 17:03:58 -0500 Received: (qmail 10507 invoked by uid 109); 14 Jan 2020 22:03:58 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 14 Jan 2020 22:03:58 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 25669 invoked by uid 111); 14 Jan 2020 22:10:13 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 14 Jan 2020 17:10:13 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 14 Jan 2020 17:03:57 -0500 From: Jeff King To: Elijah Newren via GitGitGadget Cc: git@vger.kernel.org, Elijah Newren Subject: Re: [PATCH] dir: restructure in a way to avoid passing around a struct dirent Message-ID: <20200114220357.GA3957260@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jan 14, 2020 at 04:32:12PM +0000, Elijah Newren via GitGitGadget wrote: > When I was more than a bit burned out on dir.c in late December, I had > looked at making another change to remove the need for a dirent but > punted because it looked like "way too much work". Junio and Peff both > later suggested the same cleanup, but I said it was too much work. Peff > posted a patch which demonstrated that it was actually pretty simple[1], > but I somehow read his email wrong and assumed he was commenting on my > patch (if I had looked even slightly closer...). His patch was actually > for before en/fill-directory-fixes was applied, so I have updated it > slightly to apply after that series. Yeah, I hadn't really grokked your patch, so I was hoping you'd build your stuff on top. :) > I'm not sure if I'm supposed to add a Reviewed-by me or a Signed-off-by > or both, but I read through it closely to avoid any hidden surprises. I > probably could have saved Dscho some time last month if I would have > just looked a little closer. Sorry about all that... > > (And yeah, we'll need Peff's Signed-off-by, since I'm leaving him as the > author; I really only made a small tweak to update his patch.) > > CC: Jeff King peff@peff.net [peff@peff.net], Johannes Schindelin > Johannes.Schindelin@gmx.de [Johannes.Schindelin@gmx.de] Hmm, looks like you maybe meant for more headers (and cc's) to happen than did. Anyway, I'm certainly fine with this direction, and you have my: Signed-off-by: Jeff King -Peff