From: Jonathan Tan <firstname.lastname@example.org> To: email@example.com Cc: firstname.lastname@example.org, email@example.com, Jonathan Tan <firstname.lastname@example.org> Subject: Re: [RFC] Extending git-replace Date: Tue, 14 Jan 2020 11:03:39 -0800 Message-ID: <email@example.com> (raw) In-Reply-To: <firstname.lastname@example.org> > That is, would it be sufficient if every replaced file were replaced > with the exact text "me caga en la leche" instead of a custom hand- > crafted replacement? I guess it's a bit complicated because while > that's a reasonable blob, it's not a valid commit. So maybe this > mechanism would be limited to blobs. I thought about whether we could > a different flavor of replacement for commits, but those generally have > to be custom because they each have different parents. Since the original email just discussed blobs, I'll confine myself to discussing blobs. (Commits are trickier, as you said.) > And if that would be sufficient, could promisors be used for this? I > don't know how those interact with fsck and the other commands that > you're worried about. Basically, the idea would be to use most of the > existing promisor code, and then have a mode where instead of visiting > the promisor, we just always return "me caga en la leche" (and this > does not have its SHA checked, of course). Missing promisor objects do not prevent fsck from passing - this is part of the original design (any packfiles we download from the specifically designated promisor remote are marked as such, and any objects that the objects in the packfile refer to are considered OK to be missing). Currently, when a missing object is read, it is first fetched (there are some more details that I can go over if you have any specific questions). What you're suggesting here is to return a fake blob with wrong hash - I haven't looked at all the callers of read-object functions in detail, but I don't think all of them are ready for such a behavioral change. Maybe it would be sufficient to just make this work in a more limited scope (e.g. checkout only - and if we need different replacement blobs for different object IDs, maybe we could have something similar to the clean/smudge filters). > This could work together with some sort refs/blacklist mechanism to > enable the server to choose which objects the client replaces. In the original email, Kaushik mentioned objects larger than a certain size - we already have support for that (--filter=blob:limit=1000000, for example). Having said that, Git is already able to tolerate any exclusion (of tree or blob) from the server - we already need this in order to support changing of filters, for example.
next prev parent reply index Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-14 5:33 Kaushik Srenevasan 2020-01-14 6:55 ` Elijah Newren 2020-01-14 19:11 ` Jonathan Tan 2020-01-16 3:30 ` Kaushik Srenevasan 2020-01-14 18:19 ` David Turner 2020-01-14 19:03 ` Jonathan Tan [this message] 2020-01-14 20:39 ` Elijah Newren 2020-01-14 21:57 ` Jonathan Tan 2020-01-14 22:46 ` Elijah Newren
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style List information: http://vger.kernel.org/majordomo-info.html * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ --firstname.lastname@example.org \ --email@example.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
firstname.lastname@example.org list mirror (unofficial, one of many) Archives are clonable: git clone --mirror https://public-inbox.org/git git clone --mirror http://ou63pmih66umazou.onion/git git clone --mirror http://czquwvybam4bgbro.onion/git git clone --mirror http://hjrcffqmbrq6wope.onion/git Example config snippet for mirrors Newsgroups are available over NNTP: nntp://news.public-inbox.org/inbox.comp.version-control.git nntp://ou63pmih66umazou.onion/inbox.comp.version-control.git nntp://czquwvybam4bgbro.onion/inbox.comp.version-control.git nntp://hjrcffqmbrq6wope.onion/inbox.comp.version-control.git nntp://news.gmane.io/gmane.comp.version-control.git note: .onion URLs require Tor: https://www.torproject.org/ AGPL code for this site: git clone https://public-inbox.org/public-inbox.git