From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 8FA2B1F463 for ; Tue, 7 Jan 2020 15:39:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728236AbgAGPjX (ORCPT ); Tue, 7 Jan 2020 10:39:23 -0500 Received: from cloud.peff.net ([104.130.231.41]:59276 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727559AbgAGPjX (ORCPT ); Tue, 7 Jan 2020 10:39:23 -0500 Received: (qmail 13355 invoked by uid 109); 7 Jan 2020 15:39:23 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 07 Jan 2020 15:39:23 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 31960 invoked by uid 111); 7 Jan 2020 15:44:57 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 07 Jan 2020 10:44:57 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 7 Jan 2020 10:39:22 -0500 From: Jeff King To: Derrick Stolee via GitGitGadget Cc: git@vger.kernel.org, brad@brad-smith.co.uk, sunshine@sunshineco.com, Derrick Stolee , Junio C Hamano Subject: Re: [PATCH 3/3] t4215: add bigger graph collapse test Message-ID: <20200107153922.GC20591@coredump.intra.peff.net> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Jan 07, 2020 at 02:55:47PM +0000, Derrick Stolee via GitGitGadget wrote: > From: Derrick Stolee > > A previous test in t4215-log-skewed-merges.sh was added to demonstrate > exactly the topology of a reported failure in "git log --graph". While > investigating the fix, we realized that multiple edges that could > collapse with horizontal lines were not doing so. Thanks for constructing this larger case. As for including this patch, I could take or leave it for now. I like the idea of documenting things further, but unless it's marked expect_failure, I don't think it's going to call anybody's attention more than this thread already has. So I'd love to hear what James thinks should happen here, given that it's an extension of his other work. But I'd just as soon punt on the patch until we decide whether it _should_ change (and then either mark it with expect_failure, or include the test along with a patch changing the behavior). -Peff