From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 32F6F1F463 for ; Fri, 20 Dec 2019 21:15:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727522AbfLTVP1 (ORCPT ); Fri, 20 Dec 2019 16:15:27 -0500 Received: from cloud.peff.net ([104.130.231.41]:51484 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727402AbfLTVP1 (ORCPT ); Fri, 20 Dec 2019 16:15:27 -0500 Received: (qmail 3359 invoked by uid 109); 20 Dec 2019 21:15:27 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Fri, 20 Dec 2019 21:15:27 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 15372 invoked by uid 111); 20 Dec 2019 21:20:11 -0000 Received: from coredump.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.2) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Fri, 20 Dec 2019 16:20:11 -0500 Authentication-Results: peff.net; auth=none Date: Fri, 20 Dec 2019 16:15:25 -0500 From: Jeff King To: Junio C Hamano Cc: Elijah Newren , Elijah Newren via GitGitGadget , Git Mailing List , blees@dcon.de, Kyle Meyer , Samuel Lijin Subject: Re: [PATCH v4 6/8] dir: fix checks on common prefix directory Message-ID: <20191220211525.GC2752079@coredump.intra.peff.net> References: <1f3978aa461929923eeb5037e69be6569f0ba331.1576697386.git.gitgitgadget@gmail.com> <20191219222403.GA705525@coredump.intra.peff.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Dec 20, 2019 at 10:01:21AM -0800, Junio C Hamano wrote: > In the meantime, here is to apologize for merging the patch a bit > too early to 'next'. > > -- >8 -- > From: Junio C Hamano > Date: Fri, 20 Dec 2019 09:55:53 -0800 > Subject: [PATCH] dir.c: use st_add3() for allocation size Thanks, I think this is an easy improvement worth doing (I laid out more in my response to Elijah, but: I don't think this is exploitable, but I'd rather err on the side of caution and ease of auditing). -Peff