git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
	Junio C Hamano <gitster@pobox.com>,
	Derrick Stolee <stolee@gmail.com>,
	Eric Sunshine <sunshine@sunshineco.com>
Subject: Re: [PATCH v2] t4015: improve coverage of function context test
Date: Thu, 19 Dec 2019 12:51:15 -0500	[thread overview]
Message-ID: <20191219175115.GA677976@coredump.intra.peff.net> (raw)
In-Reply-To: <86fbb0fd-6b77-5d11-69cd-f0994a8ed759@web.de>

On Thu, Dec 19, 2019 at 06:35:43PM +0100, René Scharfe wrote:

> Add a test that includes an actual function line in the test file to
> check if context is expanded to include the whole function, and add an
> ignored change before function context to check if that one stays hidden
> while the originally ignored change within function context is shown.
> 
> Helped-by: Jeff King <peff@peff.net>
> Signed-off-by: René Scharfe <l.s.r@web.de>

Thanks, the patch looks good.

Maybe worth noting in the commit message why there are two tests.
Something like:

  This differs from the existing test, which is concerned with the case
  where there is no function line at all in the file (and we might look
  past the beginning of the file).

-Peff

      reply	other threads:[~2019-12-19 17:51 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-18 18:05 [PATCH RESEND] t4015: improve coverage of function context test René Scharfe
2019-12-18 20:12 ` Jeff King
2019-12-19 17:35   ` René Scharfe
2019-12-19 17:35 ` [PATCH v2] " René Scharfe
2019-12-19 17:51   ` Jeff King [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191219175115.GA677976@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=l.s.r@web.de \
    --cc=stolee@gmail.com \
    --cc=sunshine@sunshineco.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).