From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-9.5 required=3.0 tests=AWL,BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FSL_HELO_FAKE, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RCVD_IN_MSPIKE_H3,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE, USER_IN_DEF_DKIM_WL shortcircuit=no autolearn=no autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id EE72C1F463 for ; Mon, 16 Dec 2019 22:52:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726700AbfLPWwO (ORCPT ); Mon, 16 Dec 2019 17:52:14 -0500 Received: from mail-pf1-f194.google.com ([209.85.210.194]:36786 "EHLO mail-pf1-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726682AbfLPWwN (ORCPT ); Mon, 16 Dec 2019 17:52:13 -0500 Received: by mail-pf1-f194.google.com with SMTP id x184so6432069pfb.3 for ; Mon, 16 Dec 2019 14:52:13 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=fYZASg1hXxnMa2nTXTTURaPXXdXyDq6RghkNqkhVOtc=; b=t8R3QBUmTVjYEGq29Mztiv9KjXgTsV+ltQiEUc/ZaqPJOnBUtok0j8TdfguVqZbbug 4uaxQXjR3HAKb/RzWgYvEAUB/rfz3IdEgUIdikJvpNUQVSJ+LiFIyea1Kgb7/SMDwKs7 Eewh9FfVYeNPDYtTjhqddjJVXfY+iza9JVXD4QSO81yv0Hvri+O1VUz1FWS7qMtfka8g f0ssA3VRztlGbYNppyoA2OX7/6zDbkIV4TOUzMXxSKJTlS4Aq+7jRtViE7hIp5cInibp LLuYwFS+blzvQ/CAYy+VwsvfQW4bw+Rba8WphY9tuJGAOgcwwumli2FjQhwfx6ISePMy oHcA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=fYZASg1hXxnMa2nTXTTURaPXXdXyDq6RghkNqkhVOtc=; b=I1POeHQszY9+cEeQSef32B1X4NwajdY9MARYGk83lUB3vxLZxpqyWo0zji7IX6+AgY 4Y0ZPufldS8pxhWVkRzOSFUWQn9WXNhGDWmdeoqDTOrdsqCPtKIuEOG+u+CEocdQjhu+ 6som5zKJxAxwjOKdcDfA4Go2D6QW0QTJu2HzZuW9U3RSIhCu/54l7oCPUSlPTU/sP6yt rRuJFH+hhysSwHnncfe9vHNZhrTDlUHIztdsGbuLPm/Afu2QaiCbfsox2/hNBZBpstmZ XBGTP4QQdAEPsuWxbKoi8X4hStWHBFvng+/RrqsH5GBiWpE/Zku9S23IZrEmpOE4sibQ lRNA== X-Gm-Message-State: APjAAAWV8mZCKXE4KTAxBgjQVf1idMKkHtrdlNMTDAWabVPHYXdyLHi9 EdczvFYOwyk48YBpdiL2oKoKlw== X-Google-Smtp-Source: APXvYqw5+aSH09BFD+Hrr5HNknY4d1FHAfy5g+/TnewkDXFTbnC4idpBhlABCF5nCwgqaogkmiEvvQ== X-Received: by 2002:a63:e0f:: with SMTP id d15mr21232054pgl.255.1576536732896; Mon, 16 Dec 2019 14:52:12 -0800 (PST) Received: from google.com ([2620:15c:2ce:0:231c:11cc:aa0a:6dc5]) by smtp.gmail.com with ESMTPSA id 67sm24055105pfw.82.2019.12.16.14.52.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Dec 2019 14:52:12 -0800 (PST) Date: Mon, 16 Dec 2019 14:52:07 -0800 From: Emily Shaffer To: Johannes Schindelin Cc: git@vger.kernel.org, Martin =?iso-8859-1?Q?=C5gren?= Subject: Re: [PATCH v4 09/15] bugreport: generate config safelist based on docs Message-ID: <20191216225207.GI135450@google.com> References: <20191213004312.169753-1-emilyshaffer@google.com> <20191213004312.169753-10-emilyshaffer@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Sun, Dec 15, 2019 at 09:17:57PM +0100, Johannes Schindelin wrote: > Hi Emily, > > On Thu, 12 Dec 2019, Emily Shaffer wrote: > > > diff --git a/generate-bugreport-config-safelist.sh b/generate-bugreport-config-safelist.sh > > new file mode 100755 > > index 0000000000..06b8e0c3c4 > > --- /dev/null > > +++ b/generate-bugreport-config-safelist.sh > > @@ -0,0 +1,22 @@ > > +#!/bin/sh > > + > > +cat < > +/* Automatically generated by bugreport-generate-config-safelist.sh */ > > + > > + > > +static const char *bugreport_config_safelist[] = { > > +EOF > > + > > +# cat all regular files in Documentation/config > > +find Documentation/config -type f -exec cat {} \; | > > +# print the command name which matches the bugreport-include macro > > +sed -n 's/^\(.*\) \+bugreport:include.* ::$/\1/p' | > > If you use `/ "\1",/` as replacement, you can totally avoid that ugly > `while` loop (that is unfortunately quite slow in MSYS2/Cygwin). You can > still pipe the result into `sort` just the same. Oooof. How embarrassing - I will do that.