mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Paul Mackerras <>
To: Denton Liu <>
Cc: Git Mailing List <>, Beat Bolli <>
Subject: Re: [PATCH v2 1/2] gitk: drop quotes in copysummary format
Date: Sun, 15 Dec 2019 15:19:24 +1100	[thread overview]
Message-ID: <20191215041924.GA12512@blackberry> (raw)
In-Reply-To: <>

On Thu, Dec 12, 2019 at 04:44:49PM -0800, Denton Liu wrote:
> In an earlier commit[1], git learned the 'reference' pretty format. This
> format was very similar to the format that copysummary used but it omits
> the quotes surrounding the commit's subject. Remove the quotes from the
> format in copysummary in order to match the 'reference' pretty format.
> It seems the consensus is that the unquoted form is used more often
> anyway[2] so this change should be acceptable.

I don't see any discussion about removing the quotes in the Linux
kernel community, and the Documentation/process/submitting-patches.rst
in the kernel tree says (or at least implies) that the quotes are
required.  So I am not convinced this change is a good thing to do.

In fact the gitk commit summary/reference format doesn't match what
the kernel wants exactly, in that gitk puts in the author-date, and
submitting-patches.rst doesn't have it.  There are maintainers that
have scripts that automatically check the format of Fixes: lines in
submaintainers' trees and send email if they detect one with the wrong
formatting.  Thus I would find it more convenient to change the format
to %h (\"s\") than to "%h (%s, %ad)".

Maybe the solution is to make the format customizable.

> [These commits are in git.git.]
> [1]: 1f0fc1db85 (pretty: implement 'reference' format, 2019-11-19)
> [2]: fb2ffa77a6 (SubmittingPatches: remove dq from commit reference, 2019-11-19)
> Signed-off-by: Denton Liu <>
> ---
>  gitk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> diff --git a/gitk b/gitk
> index abe4805ade..d07e3302de 100755
> --- a/gitk
> +++ b/gitk
> @@ -9429,7 +9429,7 @@ proc mktaggo {} {
>  proc copysummary {} {
>      global rowmenuid autosellen
> -    set format "%h (\"%s\", %ad)"
> +    set format "%h (%s, %ad)"
>      set cmd [list git show -s --pretty=format:$format --date=short]
>      if {$autosellen < 40} {
>          lappend cmd --abbrev=$autosellen
> -- 


  parent reply	other threads:[~2019-12-15  5:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-11 21:39 [PATCH] gitk: use --pretty=reference for copysummary Denton Liu
2019-12-11 21:58 ` Paul Mackerras
2019-12-11 22:05   ` Junio C Hamano
2019-12-13  0:44 ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Denton Liu
2019-12-13  0:44   ` [PATCH v2 1/2] gitk: drop quotes in copysummary format Denton Liu
2019-12-13 17:12     ` Junio C Hamano
2019-12-15  4:19     ` Paul Mackerras [this message]
2019-12-13  0:44   ` [PATCH v2 2/2] gitk: rename "commit summary" to "commit reference" Denton Liu
2019-12-13 17:12     ` Junio C Hamano
2019-12-15  4:36     ` Paul Mackerras
2019-12-13 17:04   ` [PATCH v2 0/2] gitk: match Git's 'reference' pretty format Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191215041924.GA12512@blackberry \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).