From: Jeff King <peff@peff.net>
To: Derrick Stolee <stolee@gmail.com>
Cc: Johannes Schindelin <Johannes.Schindelin@gmx.de>,
Thomas Braun <thomas.braun@virtuell-zuhause.de>,
git@vger.kernel.org
Subject: Re: Parallel fetch and commit graph writing results in locking failure (even on linux)
Date: Fri, 13 Dec 2019 14:52:15 -0500 [thread overview]
Message-ID: <20191213195215.GA862734@coredump.intra.peff.net> (raw)
In-Reply-To: <bdb9201f-b77f-ab3c-251f-d902c76fa9bc@gmail.com>
On Fri, Dec 13, 2019 at 02:35:47PM -0500, Derrick Stolee wrote:
> I don't think so. I think you just found a bug where the
> fetch.writeCommitGraph logic doesn't work with parallel fetch
> jobs (only one can write at a time).
>
> I believe the fix would be to write the commit-graph after
> all of the jobs have completed, which should mean we need to
> move the call to write_commit_graph_reachable() somewhere else
> inside builtin/fetch.c.
This should be fixed in master by bcb06e204c (Merge branch
'js/fetch-multi-lockfix', 2019-12-01), I think.
-Peff
next prev parent reply other threads:[~2019-12-13 19:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-13 19:20 Parallel fetch and commit graph writing results in locking failure (even on linux) Thomas Braun
2019-12-13 19:35 ` Derrick Stolee
2019-12-13 19:52 ` Jeff King [this message]
2019-12-13 19:58 ` Derrick Stolee
2019-12-15 17:19 ` Thomas Braun
2019-12-13 20:15 ` SZEDER Gábor
2019-12-15 17:35 ` german language fix: Generierung vs. Generation [was: Re: Parallel fetch and commit graph writing results in locking failure (even on linux)] Thomas Braun
2019-12-15 19:44 ` [PATCH] l10n: de.po: Reword generation numbers Ralf Thielow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191213195215.GA862734@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=stolee@gmail.com \
--cc=thomas.braun@virtuell-zuhause.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).