git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: Jonathan Nieder <jrnieder@gmail.com>,
	Ruud van Asseldonk <dev@veniogames.com>,
	git@vger.kernel.org, Paolo Bonzini <pbonzini@redhat.com>
Subject: Re: [PATCH] t5150: skip request-pull test if Perl is disabled
Date: Fri, 13 Dec 2019 02:46:59 -0500	[thread overview]
Message-ID: <20191213074659.GA95694@coredump.intra.peff.net> (raw)
In-Reply-To: <xmqqblsrz1uk.fsf@gitster-ct.c.googlers.com>

On Sun, Dec 01, 2019 at 10:19:15PM -0800, Junio C Hamano wrote:

> Jonathan Nieder <jrnieder@gmail.com> writes:
> 
> >   Not-Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
> >
> > --- the patch shouldn't be applied as is.
> > ...
> > Agreed: if we want to follow this approach, we should install stubs in
> > place of those scripts when NO_PERL=YesPlease.  Will say more about
> > this in a separate reply.
> 
> I am just leaving a note here in the thread to make sure I notice if
> there is any progress/conclusion, until which time I'll keep the
> patch on hold.  Thanks.

Thinking on this more, it might not be a bad idea to take Ruud's initial
patch here. It certainly makes things better for his NO_PERL case now,
and then in the future we can either:

 - stop building request-pull entirely with NO_PERL, but we'd still need
   the tests to realize that we shouldn't be testing it

 - change request-pull to not require perl, at which point we'd remove
   this restriction

-Peff

  reply	other threads:[~2019-12-13  7:47 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-26  0:02 [PATCH] t5150: skip request-pull test if Perl is disabled Ruud van Asseldonk
2019-11-26  0:43 ` Jonathan Nieder
2019-11-26  0:46 ` Jonathan Nieder
2019-11-27 22:42   ` Ruud van Asseldonk
2019-11-27 11:21 ` Jeff King
2019-11-27 23:45   ` Ruud van Asseldonk
2019-11-28  1:35     ` Jonathan Nieder
2019-11-28  1:31   ` Jonathan Nieder
2019-12-02  6:19     ` Junio C Hamano
2019-12-13  7:46       ` Jeff King [this message]
2019-12-16 18:32         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191213074659.GA95694@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=dev@veniogames.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=jrnieder@gmail.com \
    --cc=pbonzini@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).