mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
* [Outreachy] [PATCH v3] bisect--helper: avoid use-after-free
@ 2019-12-11 19:23 Miriam Rubio
  0 siblings, 0 replies; only message in thread
From: Miriam Rubio @ 2019-12-11 19:23 UTC (permalink / raw)
  To: git
  Cc: Tanushree Tumane, Johannes Schindelin, Christian Couder,
	Miriam Rubio, Johannes Schindelin

From: Tanushree Tumane <>

In 5e82c3dd22a (bisect--helper: `bisect_reset` shell function in C,
2019-01-02), the `git bisect reset` subcommand was ported to C. When the
call to `git checkout` failed, an error message was reported to the

However, this error message used the `strbuf` that had just been
released already. Let's switch that around: first use it, then release

Mentored-by: Johannes Schindelin <>
Mentored-by: Christian Couder <>
Signed-off-by: Tanushree Tumane <>
Signed-off-by: Miriam Rubio <>
Acked-by: Johannes Schindelin <>
This patch is a new version of
which itself has been sent previously by Tanushree

 builtin/bisect--helper.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 1fbe156e67..3055b2bb50 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -169,11 +169,12 @@ static int bisect_reset(const char *commit)
 		argv_array_pushl(&argv, "checkout", branch.buf, "--", NULL);
 		if (run_command_v_opt(argv.argv, RUN_GIT_CMD)) {
+			error(_("could not check out original"
+				" HEAD '%s'. Try 'git bisect"
+				" reset <commit>'."), branch.buf);
-			return error(_("could not check out original"
-				       " HEAD '%s'. Try 'git bisect"
-				       " reset <commit>'."), branch.buf);
+			return -1;
2.21.0 (Apple Git-122.2)

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2019-12-11 19:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-12-11 19:23 [Outreachy] [PATCH v3] bisect--helper: avoid use-after-free Miriam Rubio

Code repositories for project(s) associated with this public inbox

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).