list mirror (unofficial, one of many)
 help / color / Atom feed
From: Miriam Rubio <>
Cc: Tanushree Tumane <>,
	Johannes Schindelin <>,
	Christian Couder <>,
	Miriam Rubio <>,
	Johannes Schindelin <>
Subject: [Outreachy] [PATCH v3] bisect--helper: avoid use-after-free
Date: Wed, 11 Dec 2019 20:23:51 +0100
Message-ID: <> (raw)

From: Tanushree Tumane <>

In 5e82c3dd22a (bisect--helper: `bisect_reset` shell function in C,
2019-01-02), the `git bisect reset` subcommand was ported to C. When the
call to `git checkout` failed, an error message was reported to the

However, this error message used the `strbuf` that had just been
released already. Let's switch that around: first use it, then release

Mentored-by: Johannes Schindelin <>
Mentored-by: Christian Couder <>
Signed-off-by: Tanushree Tumane <>
Signed-off-by: Miriam Rubio <>
Acked-by: Johannes Schindelin <>
This patch is a new version of
which itself has been sent previously by Tanushree

 builtin/bisect--helper.c | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 1fbe156e67..3055b2bb50 100644
--- a/builtin/bisect--helper.c
+++ b/builtin/bisect--helper.c
@@ -169,11 +169,12 @@ static int bisect_reset(const char *commit)
 		argv_array_pushl(&argv, "checkout", branch.buf, "--", NULL);
 		if (run_command_v_opt(argv.argv, RUN_GIT_CMD)) {
+			error(_("could not check out original"
+				" HEAD '%s'. Try 'git bisect"
+				" reset <commit>'."), branch.buf);
-			return error(_("could not check out original"
-				       " HEAD '%s'. Try 'git bisect"
-				       " reset <commit>'."), branch.buf);
+			return -1;
2.21.0 (Apple Git-122.2)

                 reply index

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

  List information:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link list mirror (unofficial, one of many)

Archives are clonable:
	git clone --mirror
	git clone --mirror http://ou63pmih66umazou.onion/git
	git clone --mirror http://czquwvybam4bgbro.onion/git
	git clone --mirror http://hjrcffqmbrq6wope.onion/git

Example config snippet for mirrors

Newsgroups are available over NNTP:

 note: .onion URLs require Tor:

AGPL code for this site: git clone