From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 49AE51F463 for ; Tue, 3 Dec 2019 22:18:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727575AbfLCWSU (ORCPT ); Tue, 3 Dec 2019 17:18:20 -0500 Received: from cloud.peff.net ([104.130.231.41]:37842 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727134AbfLCWSU (ORCPT ); Tue, 3 Dec 2019 17:18:20 -0500 Received: (qmail 17581 invoked by uid 109); 3 Dec 2019 22:18:20 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Tue, 03 Dec 2019 22:18:20 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 20073 invoked by uid 111); 3 Dec 2019 22:22:25 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Tue, 03 Dec 2019 17:22:25 -0500 Authentication-Results: peff.net; auth=none Date: Tue, 3 Dec 2019 17:18:19 -0500 From: Jeff King To: Colin Stolley Cc: Junio C Hamano , SZEDER =?utf-8?B?R8OhYm9y?= , git@vger.kernel.org Subject: Re: [PATCH] packfile.c: speed up loading lots of packfiles. Message-ID: <20191203221819.GB28419@sigill.intra.peff.net> References: <20191127222453.GA3765@owl.colinstolley.com> <20191202174035.GJ23183@szeder.dev> <20191202194231.GA10707@sigill.intra.peff.net> <20191203173334.GA20027@owl.colinstolley.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20191203173334.GA20027@owl.colinstolley.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Tue, Dec 03, 2019 at 11:33:34AM -0600, Colin Stolley wrote: > Junio C Hamano wrote: > > > Let me locally squash your fix in and credit you with helped-by > > footer in the amended log message. Strictly speaking, this may > > I'm also happy to provide a khash version if that is still desired, > perhaps as a separate patch. Personally I'd be OK with it as-is, or with a conversion to khash (as I said earlier, I prefer khash myself, but it's not like there aren't tons of other hashmap.c users in the code). -Peff