From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: <git@vger.kernel.org>
Subject: [PATCH 0/1] Fix broken test with zsh as /bin/sh
Date: Wed, 27 Nov 2019 19:01:41 +0000 [thread overview]
Message-ID: <20191127190142.64271-1-sandals@crustytoothpaste.net> (raw)
macOS Catalina provides zsh as one of the three options for /bin/sh (the
other two being bash and dash). Therefore, it's possible that people
will use zsh as /bin/sh and expect it to work when running Git and the
testsuite.
There are two things required for this to happen. One is a patch to zsh
to make it run all items in a pipeline in a subshell in sh mode, just as
POSIX requires. I've sent a patch[0] upstream to make that happen;
without that patch, multiple tests fail.
The other is this patch, which addresses a difference in behavior
between bash and dash, which strip out NUL bytes from the output of a
command substitution, and zsh, which does not. Both behaviors are
permitted by POSIX, so this patch makes the test work in either case.
[0] https://www.zsh.org/mla/workers/2019/msg00960.html
brian m. carlson (1):
t9001: avoid including non-trailing NUL bytes in variables
t/t9001-send-email.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
next reply other threads:[~2019-11-27 19:01 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 19:01 brian m. carlson [this message]
2019-11-27 19:01 ` [PATCH 1/1] t9001: avoid including non-trailing NUL bytes in variables brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127190142.64271-1-sandals@crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).