git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Ed Maste <emaste@freefall.freebsd.org>
Cc: git@vger.kernel.org, Ed Maste <emaste@freebsd.org>
Subject: Re: [PATCH v2] t4210: skip i18n tests that don't work on FreeBSD
Date: Wed, 27 Nov 2019 12:20:35 -0500	[thread overview]
Message-ID: <20191127172035.GB1123@sigill.intra.peff.net> (raw)
In-Reply-To: <20191127171507.56354-1-emaste@freefall.freebsd.org>

On Wed, Nov 27, 2019 at 05:15:07PM +0000, Ed Maste wrote:

> Extend test-lib.sh to add a REGEX_ILLSEQ prereq, set it on FreeBSD, and
> add !REGEX_ILLSEQ to the two affected tests.

Thanks, this is much nicer.

> +FreeBSD)
> +	test_set_prereq REGEX_ILLSEQ
> +	test_set_prereq POSIXPERM
> +	test_set_prereq BSLASHPSPEC
> +	test_set_prereq EXECKEEPSPID
> +	;;

I scratched my head at these for a minute, but I see you are just
covering the bits set in the "*" case that we now no longer trigger.

It would probably be cleaner to set them ahead of time and just unset
them selectively in MINGW, etc. But we don't have any way to unset a
prereq, so lets' go with this for now. :)

-Peff

  reply	other threads:[~2019-11-27 17:20 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-27 15:17 [PATCH] t4210: skip i18n tests that don't work on FreeBSD Ed Maste
2019-11-27 16:24 ` Jeff King
2019-11-27 13:07   ` Ed Maste
2019-11-27 17:01     ` Jeff King
2019-11-27 17:15 ` [PATCH v2] " Ed Maste
2019-11-27 17:20   ` Jeff King [this message]
2019-11-27 13:44     ` Ed Maste
2019-12-02 11:03     ` Ed Maste
2019-12-02 17:01     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191127172035.GB1123@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=emaste@freebsd.org \
    --cc=emaste@freefall.freebsd.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).