From: Jeff King <peff@peff.net>
To: Ed Maste <emaste@freefall.freebsd.org>
Cc: git@vger.kernel.org, Ed Maste <emaste@freebsd.org>
Subject: Re: [PATCH] t4210: skip i18n tests that don't work on FreeBSD
Date: Wed, 27 Nov 2019 11:24:16 -0500 [thread overview]
Message-ID: <20191127162416.GB30581@sigill.intra.peff.net> (raw)
In-Reply-To: <20191127151708.50531-1-emaste@freefall.freebsd.org>
On Wed, Nov 27, 2019 at 03:17:08PM +0000, Ed Maste wrote:
> From: Ed Maste <emaste@freebsd.org>
>
> A number of t4210-log-i18n tests added in 4e2443b181 set LC_ALL to a UTF-8
> locale (is_IS.UTF-8) but then pass an invalid UTF-8 string to --grep.
> FreeBSD's regcomp() fails in this case with REG_ILLSEQ sequence which git
> then passes to die():
>
> fatal: command line: '�': illegal byte sequence
>
> When these tests were added the commit message stated:
>
> | It's possible that this
> | test breaks the "basic" and "extended" backends on some systems that
> | are more anal than glibc about the encoding of locale issues with
> | POSIX functions that I can remember
>
> which seems to be the case here.
Makes sense, but...
> Extend test-lib.sh to add a FREEBSD prereq (akin to MINGW) and add !FREEBSD
> to these tests.
Before we start growing more system-specific prereqs here, can we add a
layer of indirection? Convert this test to use a REGEX_ALLOW_ILLSEQ
prereq (or maybe there's a better name), and then set it for both mingw
and freebsd?
-Peff
next prev parent reply other threads:[~2019-11-27 16:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-27 15:17 [PATCH] t4210: skip i18n tests that don't work on FreeBSD Ed Maste
2019-11-27 16:24 ` Jeff King [this message]
2019-11-27 13:07 ` Ed Maste
2019-11-27 17:01 ` Jeff King
2019-11-27 17:15 ` [PATCH v2] " Ed Maste
2019-11-27 17:20 ` Jeff King
2019-11-27 13:44 ` Ed Maste
2019-12-02 11:03 ` Ed Maste
2019-12-02 17:01 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191127162416.GB30581@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=emaste@freebsd.org \
--cc=emaste@freefall.freebsd.org \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).