From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 1C72E1F464 for ; Mon, 25 Nov 2019 13:53:50 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727722AbfKYNxt (ORCPT ); Mon, 25 Nov 2019 08:53:49 -0500 Received: from cloud.peff.net ([104.130.231.41]:59892 "HELO cloud.peff.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1727462AbfKYNxs (ORCPT ); Mon, 25 Nov 2019 08:53:48 -0500 Received: (qmail 26245 invoked by uid 109); 25 Nov 2019 13:53:48 -0000 Received: from Unknown (HELO peff.net) (10.0.1.2) by cloud.peff.net (qpsmtpd/0.94) with SMTP; Mon, 25 Nov 2019 13:53:48 +0000 Authentication-Results: cloud.peff.net; auth=none Received: (qmail 18694 invoked by uid 111); 25 Nov 2019 13:57:48 -0000 Received: from sigill.intra.peff.net (HELO sigill.intra.peff.net) (10.0.0.7) by peff.net (qpsmtpd/0.94) with (TLS_AES_256_GCM_SHA384 encrypted) ESMTPS; Mon, 25 Nov 2019 08:57:48 -0500 Authentication-Results: peff.net; auth=none Date: Mon, 25 Nov 2019 08:53:47 -0500 From: Jeff King To: SZEDER =?utf-8?B?R8OhYm9y?= Cc: Junio C Hamano , =?utf-8?B?w4Z2YXIgQXJuZmrDtnLDsA==?= Bjarmason , =?utf-8?B?Tmd1eeG7hW4gVGjDoWkgTmfhu41j?= Duy , Eric Wong , git@vger.kernel.org Subject: Re: [PATCH 2/2] t5608-clone-2gb.sh: turn GIT_TEST_CLONE_2GB into a bool Message-ID: <20191125135347.GB494@sigill.intra.peff.net> References: <20190907101637.GE32087@szeder.dev> <20191122131437.25849-1-szeder.dev@gmail.com> <20191122131437.25849-3-szeder.dev@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20191122131437.25849-3-szeder.dev@gmail.com> Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On Fri, Nov 22, 2019 at 02:14:37PM +0100, SZEDER Gábor wrote: > The GIT_TEST_CLONE_2GB environment variable is only ever checked with > 'test -z' in 't5608-clone-2gb.sh', so any non-empty value is > interpreted as "yes, run these expensive tests", even > 'GIT_TEST_CLONE_2GB=NoThanks'. > > Similar GIT_TEST_* environment variables have already been turned into > bools in 3b072c577b (tests: replace test_tristate with "git > env--helper", 2019-06-21), so let's turn GIT_TEST_CLONE_2GB into a > bool as well, to follow suit. > > Our CI builds set GIT_TEST_CLONE_2GB=YesPlease, so adjust them > accordingly, thus removing the last 'YesPlease' from our CI scripts. This might break the setup of some developer or tester who put a similar value into their config.mak. But I think that's worth it to reduce confusion in the long run, especially since they will get a very clear error message due to your first patch. -Peff