From: Jeff King <email@example.com>
To: "Martin Ågren" <firstname.lastname@example.org>
Subject: Re: [PATCH] t7004: check existence of correct tag
Date: Thu, 14 Nov 2019 01:35:11 -0500 [thread overview]
Message-ID: <20191114063511.GE10643@sigill.intra.peff.net> (raw)
On Wed, Nov 13, 2019 at 08:39:02PM +0100, Martin Ågren wrote:
> We try to delete the non-existing tag "anothertag", but for the
> verifications, we check that the tag "myhead" doesn't exist. "myhead"
> isn't used in this test except for this checking. Comparing to the test
> two tests earlier, it looks like a copy-paste mistake.
Thanks, the description and patch look good to me.
> Perhaps it's overkill to check that `git tag -d` didn't decide to
> *create* a tag. But since we're trying to be this careful, let's
> actually check the correct tag. While we're doing this, let's use a more
> descriptive tag name instead -- "nonexistingtag" should be obvious.
Yes, that would be a spectacular bug indeed. :)
I think it's fine to keep it in, though, as it communicates the
expectations pretty clearly.
next prev parent reply other threads:[~2019-11-14 6:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 19:39 [PATCH] t7004: check existence of correct tag Martin Ågren
2019-11-14 6:35 ` Jeff King [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-08-08 12:47 [PATCH 1/1] delete multiple tags in a single transaction Martin Ågren
2019-08-08 12:53 ` [PATCH] t7004: check existence of correct tag Martin Ågren
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).