git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Jeff King <peff@peff.net>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, "brian m. carlson" <sandals@crustytoothpaste.net>
Subject: Re: [PATCH 0/2] getting rid of sha1_to_hex()
Date: Mon, 11 Nov 2019 04:21:44 -0500	[thread overview]
Message-ID: <20191111092144.GA12607@sigill.intra.peff.net> (raw)
In-Reply-To: <xmqqmud2hj9l.fsf@gitster-ct.c.googlers.com>

On Mon, Nov 11, 2019 at 06:09:10PM +0900, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > I happened to be looking at the oid_to_hex() family of functions today,
> > and noticed that we can drop some of the sha1-specific ones.
> >
> > It's a minor cleanup in terms of text, but it feels like a nice
> > milestone. :)
> >
> >   [1/2]: hex: drop sha1_to_hex_r()
> >   [2/2]: hex: drop sha1_to_hex()
> 
> Nice indeed.
> 
> Thanks, Brian! ;-)  oh, and Peff, of courese ;-)

I actually worried that I might be stealing brian's thunder. But AFAICT
this cleanup has been waiting for almost a year, so I figured it was
fair game. :)

-Peff

  reply	other threads:[~2019-11-11  9:21 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11  9:03 [PATCH 0/2] getting rid of sha1_to_hex() Jeff King
2019-11-11  9:04 ` [PATCH 1/2] hex: drop sha1_to_hex_r() Jeff King
2019-11-11 18:30   ` Johannes Schindelin
2019-11-11  9:04 ` [PATCH 2/2] hex: drop sha1_to_hex() Jeff King
2019-11-11 14:18   ` SZEDER Gábor
2019-11-11 14:29     ` Jeff King
2019-11-12  4:13       ` Junio C Hamano
2019-11-12 10:57         ` Jeff King
2019-11-12 11:44           ` SZEDER Gábor
2019-11-12 12:12             ` Jeff King
2019-11-12 11:49           ` Junio C Hamano
2019-11-12 12:15             ` Jeff King
2019-11-13  1:09               ` Junio C Hamano
2019-11-13  1:15                 ` Jeff King
2019-11-11  9:09 ` [PATCH 0/2] getting rid of sha1_to_hex() Junio C Hamano
2019-11-11  9:21   ` Jeff King [this message]
2019-11-11 23:53     ` brian m. carlson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191111092144.GA12607@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=sandals@crustytoothpaste.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).