From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Lars Schneider <larsxschneider@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] utf8: use skip_iprefix() in same_utf_encoding()
Date: Fri, 8 Nov 2019 17:20:48 -0500 [thread overview]
Message-ID: <20191108222048.GA18554@sigill.intra.peff.net> (raw)
In-Reply-To: <b27cc95d-8cb8-db49-c2d1-3eb591624000@web.de>
On Fri, Nov 08, 2019 at 09:25:21PM +0100, René Scharfe wrote:
> Get rid of magic numbers by using skip_iprefix() and skip_prefix() for
> parsing the leading "[uU][tT][fF]-?" of both strings instead of checking
> with istarts_with() and an explicit comparison.
Yeah, I think the result is much easier to understand. I didn't look
closely at it, but the generated asm seems to be slightly shorter, too.
-Peff
prev parent reply other threads:[~2019-11-08 22:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-08 20:25 [PATCH] utf8: use skip_iprefix() in same_utf_encoding() René Scharfe
2019-11-08 22:20 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191108222048.GA18554@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=larsxschneider@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).