From: Jonathan Tan <jonathantanmy@google.com>
To: peff@peff.net
Cc: simon.holmberg@avalanchestudios.se, git@vger.kernel.org,
Jonathan Tan <jonathantanmy@google.com>
Subject: Re: Partial Clone garbage collection?
Date: Wed, 30 Oct 2019 13:45:16 -0700 [thread overview]
Message-ID: <20191030204516.53832-1-jonathantanmy@google.com> (raw)
In-Reply-To: <20191030203714.GC29013@sigill.intra.peff.net>
> I don't recall seeing anybody actively working on this, but I think it
> would be a good idea.
I agree with this.
> You could naively just drop everything that matches the filter, and then
> re-fetch it as needed.
We should also retain the promisor objects that are not referenced by
any other promisor object, regardless of whether it matches the filter.
(If not, the resulting repository will not pass fsck.)
The place to make this change is most likely in
repack_promisor_objects() in builtin/repack.c. Currently, it just
repacks all known promisor objects into one - modifying it to only
repack the ones we want (and adding a CLI option etc.) should be
sufficient.
prev parent reply other threads:[~2019-10-30 20:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CA+M_GG35V3yNCfQ247PSrpP-R_f8bWNcBcmrnTWbrn1Nap_A4A@mail.gmail.com>
2019-10-30 17:08 ` Partial Clone garbage collection? Simon Holmberg
2019-10-30 18:17 ` без имени
2019-10-30 20:38 ` Jeff King
2019-10-30 20:37 ` Jeff King
2019-10-30 20:45 ` Jonathan Tan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191030204516.53832-1-jonathantanmy@google.com \
--to=jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=simon.holmberg@avalanchestudios.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).