From: Konstantin Ryabitsev <konstantin@linuxfoundation.org>
To: Jeff King <peff@peff.net>
Cc: Derrick Stolee <stolee@gmail.com>,
git@vger.kernel.org, Taylor Blau <me@ttaylorr.com>
Subject: Re: is commitGraph useful on the server side?
Date: Tue, 22 Oct 2019 16:39:23 -0400 [thread overview]
Message-ID: <20191022203923.GA3020@chatter.i7.local> (raw)
In-Reply-To: <20191022200615.GA12270@sigill.intra.peff.net>
On Tue, Oct 22, 2019 at 04:06:16PM -0400, Jeff King wrote:
>> I'm biased, but I think the commit-graph is generally really good to
>> have
>> in almost all cases. I actually do not know of a good reason to _not_ have
>> it.
>
>A lot depends on how much you do on the server. If you're serving a web
>interface that runs things like `rev-list`, or `for-each-ref
>--contains`, etc, then you should see a big improvement.
Ah, good to know, so something like cgit would see an improvement if
there are commit graphs generated for the repos it serves.
>If you're _just_ serving fetches with `upload-pack`, you might see some
>small improvement during fetch negotiation. But I suspect it would be
>dwarfed by the cost of actually generating packs. Likewise, the
>traversal there will be dominated by accessing trees (and if that is
>expensive, then you ought to be using reachability bitmaps).
We do generate bitmaps on a routine basis.
OK, I think I'm convinced that enabling commitgraph and generating them
regularly is going to be a net win.
Thanks, everyone.
-K
next prev parent reply other threads:[~2019-10-22 20:39 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-22 16:51 is commitGraph useful on the server side? Konstantin Ryabitsev
2019-10-22 19:44 ` Derrick Stolee
2019-10-22 20:06 ` Jeff King
2019-10-22 20:39 ` Konstantin Ryabitsev [this message]
2019-10-22 20:07 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191022203923.GA3020@chatter.i7.local \
--to=konstantin@linuxfoundation.org \
--cc=git@vger.kernel.org \
--cc=me@ttaylorr.com \
--cc=peff@peff.net \
--cc=stolee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).