From: "brian m. carlson" <sandals@crustytoothpaste.net>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org, Duy Nguyen <pclouds@gmail.com>,
Junio C Hamano <gitster@pobox.com>
Subject: Re: [PATCH] remote-curl: pass on atomic capability to remote side
Date: Wed, 16 Oct 2019 23:43:06 +0000 [thread overview]
Message-ID: <20191016234306.tqaszjc2sfxqg3zr@camp.crustytoothpaste.net> (raw)
In-Reply-To: <20191015164028.GA4710@sigill.intra.peff.net>
[-- Attachment #1: Type: text/plain, Size: 1375 bytes --]
On 2019-10-15 at 16:40:29, Jeff King wrote:
> On Tue, Oct 15, 2019 at 01:07:59AM +0000, brian m. carlson wrote:
> > diff --git a/Documentation/gitremote-helpers.txt b/Documentation/gitremote-helpers.txt
> > index a5c3c04371..670d72c174 100644
> > --- a/Documentation/gitremote-helpers.txt
> > +++ b/Documentation/gitremote-helpers.txt
> > @@ -509,6 +509,11 @@ set by Git if the remote helper has the 'option' capability.
> > Indicate that only the objects wanted need to be fetched, not
> > their dependents.
> >
> > +'option atomic' {'true'|'false'}::
> > + When pushing, request the remote server to update refs in a single atomic
> > + transaction. If successful, all refs will be updated, or none will. If the
> > + remote side does not support this capability, the push will fail.
> > +
>
> This is implemented with a single space, but the rest of the option
> bodies are indented with a tab. Asciidoc seems to format it identically
> either way, though.
Yeah, my default editor configuration for AsciiDoc is two spaces. I
noticed that Junio's already picked it up for next, but I'll send a v2
with this fixed in case he wants to merge the fixed version to master
instead.
If it's more convenient, I can send a follow-up patch fixing the whitespace.
--
brian m. carlson: Houston, Texas, US
OpenPGP: https://keybase.io/bk2204
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 868 bytes --]
next prev parent reply other threads:[~2019-10-16 23:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-15 1:07 [PATCH] remote-curl: pass on atomic capability to remote side brian m. carlson
2019-10-15 16:40 ` Jeff King
2019-10-16 23:43 ` brian m. carlson [this message]
2019-10-17 7:05 ` Junio C Hamano
2019-10-16 23:45 ` [PATCH v2] " brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016234306.tqaszjc2sfxqg3zr@camp.crustytoothpaste.net \
--to=sandals@crustytoothpaste.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).