From: Jonathan Nieder <jrnieder@gmail.com>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: workflows@vger.kernel.org, Git Mailing List <git@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Konstantin Ryabitsev <konstantin@linuxfoundation.org>,
Eric Wong <e@80x24.org>
Subject: Re: email as a bona fide git transport
Date: Wed, 16 Oct 2019 13:57:36 -0700 [thread overview]
Message-ID: <20191016205736.GA259536@google.com> (raw)
In-Reply-To: <b9fb52b8-8168-6bf0-9a72-1e6c44a281a5@oracle.com>
Hi,
A few small points.
Vegard Nossum wrote:
> * git am (or an alternative command) needs to recreate the commit
> perfectly when applied, including applying it to the correct parent
Interesting. "git format-patch" has a --base option to do some of
what you're looking for, for the sake of snowpatch
<https://github.com/ruscur/snowpatch>. Though it's not exactly the
same thing you mean.
We also discussed sending merge commits by mail recently in the
virtual git committer summit[1].
Of course, the devil is in the details. It's straightforward to use
"git bundle" to use mail as a Git transport today, but presumably you
also want the ability to perform reviews along the way and that's not
so easy with a binary format. Do you have more details on what you'd
want the format to look like, particularly for merge commits?
[...]
> there
> is no need for "changeset IDs" or whatever, since you can just use the
> git SHA1 which is unique, unambiguous, and stable.
In [2] the hope was for some identifier that is preserved by "git
rebase" and "git commit --amend" (so that you can track the evolution
of a change as the author improves it in response to reviews). Is
that the conversation you're alluding to?
[...]
> Disadvantages:
>
> - requires patching git
That's not a disadvantage. It means get to work with the Git project,
which is a welcoming bunch of people, working on userspace (seeing how
the other half lives), and improving the lives of everyone using Git.
[...]
> Date: Sat, 5 Oct 2019 16:15:59 +0200
> Subject: [PATCH 1/3] format-patch: add --complete
>
> Include the raw commit data between the changelog and the diffstat.
Oh! I had missed this on first reading because it was in an
attachment.
I have mixed feelings. Can you say a bit more about the advantages
and disadvantages relative to sending a git bundle? What happens if a
mail client or a box along the way mangles whitespace in the commit
message?
Happy hacking,
Jonathan
[1] https://public-inbox.org/git/nycvar.QRO.7.76.6.1909261253400.15067@tvgsbejvaqbjf.bet/
[2] https://lore.kernel.org/ksummit-discuss/CAD=FV=UPjPpUyFTPjF-Ogzj_6LJLE4PTxMhCoCEDmH1LXSSmpQ@mail.gmail.com/
next prev parent reply other threads:[~2019-10-16 20:57 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-16 10:22 email as a bona fide git transport Vegard Nossum
2019-10-16 11:10 ` Willy Tarreau
2019-10-16 14:45 ` Santiago Torres Arias
2019-10-17 20:43 ` Greg KH
2019-10-17 20:45 ` Konstantin Ryabitsev
2019-10-18 1:30 ` Greg KH
2019-10-18 1:54 ` Konstantin Ryabitsev
2019-10-18 2:52 ` Willy Tarreau
2019-10-18 6:34 ` Nicolas Belouin
2019-10-18 15:50 ` Santiago Torres Arias
2019-10-20 5:50 ` Laurent Pinchart
2019-10-18 14:27 ` Vegard Nossum
2019-10-18 15:54 ` Santiago Torres Arias
2019-10-18 16:03 ` Konstantin Ryabitsev
2019-10-18 16:11 ` Santiago Torres Arias
2019-10-18 18:00 ` Konstantin Ryabitsev
2019-10-18 16:15 ` Theodore Y. Ts'o
2019-10-18 16:50 ` Vegard Nossum
2019-10-18 19:14 ` Theodore Y. Ts'o
2019-10-20 3:17 ` Willy Tarreau
2019-10-20 6:28 ` Vegard Nossum
2019-10-22 12:11 ` Vegard Nossum
2019-10-22 13:53 ` Theodore Y. Ts'o
2019-10-22 16:29 ` Vegard Nossum
2019-10-22 19:01 ` Eric Wong
2019-10-16 15:00 ` Pratyush Yadav
2019-10-17 12:23 ` Vegard Nossum
2019-10-17 13:11 ` Theodore Y. Ts'o
2019-10-17 14:01 ` Vegard Nossum
2019-10-17 14:47 ` Theodore Y. Ts'o
2019-10-17 15:11 ` Steven Rostedt
2019-10-16 20:57 ` Jonathan Nieder [this message]
2019-10-17 13:08 ` Vegard Nossum
2019-10-17 3:17 ` Junio C Hamano
2019-10-17 13:30 ` Vegard Nossum
2019-10-18 2:22 ` Eric Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191016205736.GA259536@google.com \
--to=jrnieder@gmail.com \
--cc=e@80x24.org \
--cc=git@vger.kernel.org \
--cc=konstantin@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
--cc=workflows@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).