From: Wambui Karuga <wambui.karugax@gmail.com>
To: Jonathan Tan <jonathantanmy@google.com>
Cc: git@vger.kernel.org
Subject: Re: [Outreachy] [PATCH] blame: Convert pickaxe_blame defined constants to enums
Date: Fri, 11 Oct 2019 23:04:51 +0300 [thread overview]
Message-ID: <20191011200451.GA25862@wambui> (raw)
In-Reply-To: <20191011184803.104907-1-jonathantanmy@google.com>
On Fri, Oct 11, 2019 at 11:48:03AM -0700, Jonathan Tan wrote:
> > > Any reason why the names are renamed to omit "PICKAXE_"? In particular,
> > > these names are still global, so it is good to retain the extra context.
> > >
> > > (This doesn't mean that you are wrong to remove them - I just gave my
> > > opinion, and a reason for my opinion. If you had a reason to remove
> > > them, you can mention that, and we can discuss this together. Or, if you
> > > read my reason and agree with it, you can say that and put the
> > > "PICKAXE_" back.)
> > >
> > I wasn't really sure about omitting the "PICKAXE_" prefix, but I looked
> > at some of the other defined enums and it seemed like what would act as
> > the prefix in #defines was only used in the enum declaration. For
> > example I looked at:
> > enum apply_ws_error_action {
> > nowarn_ws_error,
> > warn_on_ws_error,
> > die_on_ws_error,
> > correct_ws_error
> > };
> >
> > For comparison, I took "apply_" as the prefix that would translate to
> > "#define APPLY_" which isn't included in the member variables.
> > I do agree about retaining the extra context though, so I can definitely put the
> > "PICKAXE_" back.
>
> [snip]
>
> > > In Git, we often look at historical commits, so it is good to keep
> > > history as clean as possible. In particular, we shouldn't move things
> > > around unless we have another reason to. Here, for example, you are
> > > moving the constants from above BLAME_DEFAULT_* to below. You should
> > > move them back. (Or if you have a reason for moving, mention that and we
> > > can discuss it.)
> > >
> > I'll move them back. I have experience with all the "#define" constants
> > being immediately after the "#includes" which is why I moved them, but I'll
> > try to stick to the
> > convention from now on.
>
> Thanks for providing your justifications.
>
> > > Also, I have a slight preference for putting "= 02" on the BLAME_COPY
> > > line but that is not necessary.
> > >
> > Noted.
>
> Well, Junio provides a good reason for putting "= 02" [1], so please do
> that.
>
> [1] https://public-inbox.org/git/xmqqsgnzj4vs.fsf@gitster-ct.c.googlers.com/
Yes, I'll include it in an updated patch
Thanks
wambui karuga
prev parent reply other threads:[~2019-10-11 20:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-10 11:52 [Outreachy] [PATCH] blame: Convert pickaxe_blame defined constants to enums Wambui Karuga
2019-10-10 18:44 ` Jonathan Tan
2019-10-11 4:13 ` Junio C Hamano
2019-10-11 18:44 ` Jonathan Tan
2019-10-12 0:30 ` Junio C Hamano
2019-10-14 18:27 ` Jonathan Tan
2019-10-14 19:37 ` Wambui Karuga
2019-10-14 21:46 ` Jonathan Tan
2019-10-15 12:06 ` Wambui Karuga
2019-10-15 8:45 ` SZEDER Gábor
2019-10-11 8:52 ` Wambui Karuga
2019-10-11 18:48 ` Jonathan Tan
2019-10-11 20:04 ` Wambui Karuga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191011200451.GA25862@wambui \
--to=wambui.karugax@gmail.com \
--cc=20191011184803.104907-1-jonathantanmy@google.com \
--cc=git@vger.kernel.org \
--cc=jonathantanmy@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).