From: Pratyush Yadav <me@yadavpratyush.com>
To: Birger Skogeng Pedersen <birger.sp@gmail.com>
Cc: Git List <git@vger.kernel.org>, Johannes Sixt <j6t@kdbg.org>
Subject: Re: git-gui: automatically move focus to staged file before typing commit message?
Date: Tue, 8 Oct 2019 23:29:38 +0530 [thread overview]
Message-ID: <20191008175938.iqibournnxam4r6d@yadavpratyush.com> (raw)
In-Reply-To: <CAGr--=KXpt7GzqPpm1BCrsc1jhfaXeCT-XrWKNvq2pLtgAbSwQ@mail.gmail.com>
On 07/10/19 06:52PM, Birger Skogeng Pedersen wrote:
> So I kinda got this working, but only when focusing the commit message widget.
Isn't this the point of your feature? You change the view when focusing
the commit message widget. I remember you were explicitly against doing
it as soon as all unstaged files were staged. Did you change your point
of view on that?
> I did not manage to get it working when invoking "do_add_all", (e.g.
> when pressing CTRL/CMD+i). I added this:
>
> bind $ui_comm <$M1B-Key-i> {do_add_all;select_staged_file;break}
> bind $ui_comm <$M1B-Key-I> {do_add_all;select_staged_file;break}
>
> But it seems that the "select_staged_file" procedure is invoked
> _before_ "do_add_all" finishes. So that's not working. All changes
> gets staged, but no staged change is selected.
Hmm, that shouldn't happen. select_staged_file should be executed
_after_ do_add_all, not before. I haven't looked into your patches yet
though.
> And I'm quite stuck. Do I send the unfinished patch, so maybe I can
> get some advice? Or is it better to just wait until I have the perfect
> patch ready?
If you are stuck on something, and want to share the WIP feature to get
help/comments, you should mark your patches as "RFC" (Request For
Comments). This can be done by passing the option '-rfc' to
`git-format-patch`. This will make your subject prefix to "RFC PATCH"
instead of just "PATCH".
And yes, it is perfectly OK to send incomplete changes as long as you
mark them as such, and specify what you need help with.
But I see that you have already sent those patches. I'm not sure when I
can find time to tinker around with them, so it might take me a couple
of days to get to them.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-10-08 17:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-14 12:24 git-gui: automatically move focus to staged file before typing commit message? Birger Skogeng Pedersen
2019-09-14 21:15 ` Pratyush Yadav
2019-09-14 21:26 ` Johannes Sixt
2019-09-14 21:27 ` Pratyush Yadav
2019-09-15 7:55 ` Birger Skogeng Pedersen
2019-09-16 18:01 ` Pratyush Yadav
2019-09-26 18:33 ` Birger Skogeng Pedersen
2019-09-26 19:30 ` Pratyush Yadav
2019-09-26 21:17 ` Birger Skogeng Pedersen
2019-10-07 16:52 ` Birger Skogeng Pedersen
2019-10-07 17:11 ` [PATCH 1/2] git-gui: implement proc select_path_in_widget Birger Skogeng Pedersen
2019-10-07 17:11 ` [PATCH 2/2] git-gui: select staged on ui_comm focus Birger Skogeng Pedersen
2019-10-16 19:25 ` Pratyush Yadav
2019-10-13 20:21 ` [PATCH 1/2] git-gui: implement proc select_path_in_widget Pratyush Yadav
2019-10-15 10:51 ` Birger Skogeng Pedersen
2019-10-16 19:28 ` Pratyush Yadav
2019-10-17 5:08 ` Birger Skogeng Pedersen
2019-10-17 5:33 ` Johannes Sixt
2019-10-17 6:54 ` Birger Skogeng Pedersen
2019-10-17 18:28 ` Pratyush Yadav
2019-10-08 17:59 ` Pratyush Yadav [this message]
2019-10-08 19:46 ` git-gui: automatically move focus to staged file before typing commit message? Birger Skogeng Pedersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191008175938.iqibournnxam4r6d@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).