From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-3.9 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id B4AD31F4BD for ; Sat, 5 Oct 2019 21:11:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1725852AbfJEVLk (ORCPT ); Sat, 5 Oct 2019 17:11:40 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:52353 "EHLO relay5-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725789AbfJEVLj (ORCPT ); Sat, 5 Oct 2019 17:11:39 -0400 X-Originating-IP: 1.186.12.44 Received: from localhost (unknown [1.186.12.44]) (Authenticated sender: me@yadavpratyush.com) by relay5-d.mail.gandi.net (Postfix) with ESMTPSA id C439B1C0002; Sat, 5 Oct 2019 21:11:36 +0000 (UTC) Date: Sun, 6 Oct 2019 02:41:34 +0530 From: Pratyush Yadav To: Bert Wesarg Cc: Git Mailing List , Johannes Schindelin , Junio C Hamano Subject: Re: [PATCH] git-gui: add a readme Message-ID: <20191005211134.fkuwvuztck2k3heu@yadavpratyush.com> References: <20191004221052.23313-1-me@yadavpratyush.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 05/10/19 12:51PM, Bert Wesarg wrote: > On Sat, Oct 5, 2019 at 12:10 AM Pratyush Yadav wrote: > > +# Contributing > > + > > +The project is currently maintained by Pratyush Yadav over at > > +https://github.com/prati0100/git-gui. Even though the project is hosted at > > +GitHub, the development does not happen over GitHub Issues and Pull Requests. > > +Instead, an email based workflow is used. The git mailing list > > +[git@vger.kernel.org](mailto:git@vger.kernel.org) is where the patches are > > +discussed and reviewed. > > + > > +More information about the git mailing list and instructions to subscribe can > > +be found [here](https://git.wiki.kernel.org/index.php/GitCommunity). > > + > > +## Sending your changes > > + > > +Since the development happens over email, you need to send in your commits in > > +text format. Commits can be converted to emails via the two tools provided by > > +git: `git-send-email` and `git-format-patch`. > > + > > +If you are sending multiple patches, it is recommended to include a cover > > +letter. A cover letter is an email explaining in brief what the series is > > +supposed to do. A cover letter template can be generated by passing > > +`--cover-letter` to `git-format-patch`. > > + > > +After you send your patches, you might get a review suggesting some changes. > > +Make those changes, and re-send your patch(es) in reply to the first patch of > > +your initial version. Also please mention the version of the patch. This can be > > +done by passing `-v X` to `git-format-patch`, where 'X' is the version number > > +of the patch(es). > > + > > +### Using git-send-email > > + > > +You can use `git-send-email` to send patches via email. A pretty good guide to > > +configuring and using `git-send-email` can be found > > +[here](https://www.freedesktop.org/wiki/Software/PulseAudio/HowToUseGitSendEmail/) > > + > > +### Using your email client > > + > > +If your email client supports sending mbox format emails, you can use > > +`git-format-patch` to get an mbox file for each commit, and then send them. If > > +there is more than one patch in the series, then all patches after the first > > +patch (or the cover letter) need to be sent as replies to the first. > > +`git-send-email` does this by default. > > + > > Junio mentioned (at least?) once [1], that using only git-send-email > is not a good workflow. Instead one should use git-format-patch to > generate the patches, audit them. and then use git-send-email. I > second this. > > Please switch these two sections to encompass this. Thanks for pointing it out. Will fix. > Thanks. > > Bert > > [1] https://public-inbox.org/git/xmqqh9n241el.fsf@gitster.mtv.corp.google.com/ -- Regards, Pratyush Yadav