From: Pratyush Yadav <me@yadavpratyush.com>
To: Johannes Schindelin <Johannes.Schindelin@gmx.de>
Cc: harish k <harish2704@gmail.com>,
git@vger.kernel.org, David Aguilar <davvid@gmail.com>
Subject: Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts
Date: Fri, 4 Oct 2019 17:31:07 +0530 [thread overview]
Message-ID: <20191004120107.kpskplwhflnsamwu@yadavpratyush.com> (raw)
In-Reply-To: <nycvar.QRO.7.76.6.1910041046000.46@tvgsbejvaqbjf.bet>
On 04/10/19 10:49AM, Johannes Schindelin wrote:
> Hi Pratyush,
>
> please don't top-post on this list (yet another of these things
> requiring extra brain cycles in the mailing list workflow).
I didn't top-post, or at least it wasn't the intention. The text above
the quoted text is the "preface" (just like this line I'm replying to is
a "preface"). It was a comment on the patch formatting, and it wouldn't
make sense (at least to me) to have it _below_ the quoted part,
especially since I did have comments in-line (IOW, bottom-posted).
Maybe because I included the references in the middle of the text you
thought the message was over (understandably so. I probably shouldn't do
that), and didn't scroll till the end to read the rest of the message.
Or maybe I don't know something about email etiquette that I should.
> On Fri, 4 Oct 2019, Pratyush Yadav wrote:
>
> > Hi Harish,
> >
> > Thanks for the patch. Unfortunately, it seems your mail client messed up
> > the formatting, and the patch won't apply. I'm guessing it is because
> > your mail client broke long lines into two, messing up the diff.
> >
> > We use an email-based workflow, so please either configure your mail
> > client so it doesn't munge patches, or use `git send-email`. You can
> > find a pretty good tutorial on sending patches via email over at [0].
> > The tutorial is for git.git, but works for git-gui.git as well.
>
> Ah, well. Mailing list-based workflows are so easy, amirite? They are so
> welcoming and inclusive, yes?
> </sarcasm>
>
> > If you feel more comfortable with GitHub pull requests, please take a
> > look at Gitgitgadget [1]. Johannes (in Cc) has used it recently to send
> > patches based on the git-gui repo (AFAIK, it was originally designed
> > only for the git.git repo). Maybe ask the folks over there how they do
> > it.
>
> Harish, it is actually relatively easy to use GitGitGadget: just add a
> remote like this:
>
> git remote add gitgitgadget https://github.com/gitgitgadget/git
> git fetch gitgitgadget git-gui/master
>
> and then rebase your patch on top of that branch:
>
> git rebase -i --onto git-gui/master HEAD~1
>
> Then force-push your branch to your GitHub fork of git.git and open a
> Pull Request at https://github.com/gitgitgadget/git/pulls, targeting
> git-gui/master.
>
> GitGitGadget will welcome you with a (hopefully) helpful message ;-)
Thanks for these instructions. I will include them in a "Contributing"
document I'm writing for git-gui.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-10-04 12:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-29 11:38 [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts Harish K
2016-03-31 16:41 ` David Aguilar
2016-04-01 6:32 ` harish k
2019-10-03 14:48 ` harish k
2019-10-03 21:44 ` Pratyush Yadav
2019-10-04 8:49 ` Johannes Schindelin
2019-10-04 12:01 ` Pratyush Yadav [this message]
2019-10-05 20:16 ` Harish Karumuthil
2019-10-05 21:01 ` Pratyush Yadav
2019-10-06 9:49 ` Johannes Schindelin
2019-10-06 18:39 ` Pratyush Yadav
2019-10-06 19:37 ` Philip Oakley
2019-10-06 20:27 ` Johannes Schindelin
2019-10-06 21:06 ` Pratyush Yadav
2019-10-07 9:20 ` GitGUIGadget, was " Johannes Schindelin
2019-10-07 10:43 ` Birger Skogeng Pedersen
2019-10-07 19:16 ` Alban Gruin
2019-11-19 22:09 ` Making GitGitGadget's list -> PR comment mirroring bidirectional, " Johannes Schindelin
2019-11-20 14:22 ` Pratyush Yadav
2019-10-06 22:40 ` Philip Oakley
2019-10-07 6:22 ` Harish Karumuthil
2019-10-07 10:01 ` Johannes Schindelin
2019-10-08 19:31 ` Harish Karumuthil
2019-10-09 20:42 ` Johannes Schindelin
2019-10-13 20:09 ` Pratyush Yadav
2019-10-07 6:13 ` Harish Karumuthil
2019-10-13 19:17 ` Pratyush Yadav
-- strict thread matches above, loose matches on Subject: below --
2016-03-29 11:29 Harish K
2016-03-31 16:49 ` David Aguilar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191004120107.kpskplwhflnsamwu@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=davvid@gmail.com \
--cc=git@vger.kernel.org \
--cc=harish2704@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).