From: Pratyush Yadav <me@yadavpratyush.com>
To: Thomas Klaeger via GitGitGadget <gitgitgadget@gmail.com>
Cc: git@vger.kernel.org,
Johannes Schindelin <johannes.schindelin@gmx.de>,
Junio C Hamano <gitster@pobox.com>,
Thomas Klaeger <thklaeger@gmail.com>
Subject: Re: [PATCH 1/1] git-gui (Windows): use git-bash.exe if it is available
Date: Tue, 1 Oct 2019 19:16:54 +0530 [thread overview]
Message-ID: <20191001134654.vpiygrpczegynfis@yadavpratyush.com> (raw)
In-Reply-To: <414cf2c89876fe122ee18f8d6533f083c2f65654.1569519977.git.gitgitgadget@gmail.com>
On 26/09/19 10:46AM, Thomas Klaeger via GitGitGadget wrote:
> From: Thomas Klaeger <thklaeger@gmail.com>
>
> Git for Windows 2.x ships with an executable that starts the Git Bash
> with all the environment variables and what not properly set up. It is
> also adjusted according to the Terminal emulator option chosen when
> installing Git for Windows (while `bash.exe --login -i` would always
> launch with Windows' default console).
>
> So let's use that executable (usually C:\Program Files\Git\git-bash.exe)
> instead of `bash.exe --login -i` if its presence was detected.
>
> This fixes https://github.com/git-for-windows/git/issues/490
>
> Signed-off-by: Thomas Kläger <thomas.klaeger@10a.ch>
While applying the patch, my patch check script complained that the
author did not sign off.
Well, they did... but with a slightly different name (Kläger vs
Klaeger) and a completely different email address.
I'm not sure if I can do something about it, just thought it was
something worth mentioning.
--
Regards,
Pratyush Yadav
prev parent reply other threads:[~2019-10-01 13:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 17:46 [PATCH 0/1] git-gui (Windows): use git-bash.exe if it is available Johannes Schindelin via GitGitGadget
2019-09-26 17:46 ` [PATCH 1/1] " Thomas Klaeger via GitGitGadget
2019-09-26 21:57 ` Pratyush Yadav
2019-09-30 10:27 ` Johannes Schindelin
2019-10-01 5:28 ` Johannes Sixt
2019-10-01 12:38 ` Pratyush Yadav
2019-10-01 13:46 ` Pratyush Yadav [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191001134654.vpiygrpczegynfis@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
--cc=johannes.schindelin@gmx.de \
--cc=thklaeger@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).