From: Pratyush Yadav <me@yadavpratyush.com>
To: Johannes Sixt <j6t@kdbg.org>
Cc: Birger Skogeng Pedersen <birger.sp@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: git-gui: disable the "loose objects popup" dialog?
Date: Fri, 27 Sep 2019 00:45:45 +0530 [thread overview]
Message-ID: <20190926191545.ro7w6lbtlpbyxpk7@yadavpratyush.com> (raw)
In-Reply-To: <91e5b3b0-08f9-66a8-ebdf-90effd34c888@kdbg.org>
On 26/09/19 08:54PM, Johannes Sixt wrote:
> Am 26.09.19 um 19:31 schrieb Birger Skogeng Pedersen:
> > Every once in a while, I get the "This repository currently has
> > approximately (some number) loose objects." popup dialog.
> >
> > I don't want to sound arrogant, but I find this popup along with the
> > dialog showing after that prints the result of the compression,
> > immensely annoying. And I've seen people mention before that they
> > would, in some casese, rather not have to deal with the dialog[0].
> >
> > [0] https://stackoverflow.com/questions/1106529/how-to-skip-loose-object-popup-when-running-git-gui
> >
> > I get that git-gui merely wants to resolve a performance issue. But
> > personally I'd prefer if git could just assume I always wanted to
> > compress the database, and automatically do it without bugging me with
> > the popups.
>
> I dislike the popup, too. But I want total control over my repository:
> No automatic compression behind my back, in particular, when that
> expires reflogs, and git-gui does that.
I agree. Doing stuff like this in background by default is not the best
idea IMHO. If the user asks explicitly, fine, but don't do it by
default.
> > I propose we implement the following options in git-gui:
> > - ignore loose objects (do not show the popup), disabled by default.
Reading the Stackoverflow link, it seems this is already possible via an
undocumented config variable "gui.gcwarning". I haven't tried using it
though, but I see no reason for it to not work (looking at
git-gui.sh:4141).
Maybe we should add this variable in the options dialog, so people at
least know it exists?
> > - automatically, silently compress the database, without prompt. Also
> > disabled by default.
>
> What about a configurable limit, but still show the dialog?
Do people really care that much about configuring this limit to warrant
something like this?
Talking about auto compression, would it be a better idea to let users
disable the dialog, and then if they do want auto compression, they can
just run a cron job (or the Windows equivalent) to do this on their
repos? What reasons do people have to have this feature in git-gui,
instead of running cron jobs?
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-09-26 19:15 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-26 17:31 git-gui: disable the "loose objects popup" dialog? Birger Skogeng Pedersen
2019-09-26 18:54 ` Johannes Sixt
2019-09-26 19:13 ` Birger Skogeng Pedersen
2019-09-26 19:15 ` Pratyush Yadav [this message]
2019-09-26 21:12 ` Birger Skogeng Pedersen
2019-09-26 21:13 ` Johannes Sixt
2019-10-01 18:00 ` Pratyush Yadav
2019-10-02 7:12 ` Birger Skogeng Pedersen
2019-10-02 18:48 ` Johannes Sixt
2019-10-02 20:41 ` Marc Branchaud
2019-09-26 21:14 ` Marc Branchaud
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190926191545.ro7w6lbtlpbyxpk7@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
--cc=j6t@kdbg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).