From: Pratyush Yadav <me@yadavpratyush.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Denton Liu <liu.denton@gmail.com>,
Birger Skogeng Pedersen <birger.sp@gmail.com>,
Git List <git@vger.kernel.org>
Subject: Re: git-gui: missing some patches from git?
Date: Thu, 19 Sep 2019 00:52:22 +0530 [thread overview]
Message-ID: <20190918192222.rqn3oqxfeu7bmnp5@yadavpratyush.com> (raw)
In-Reply-To: <xmqqblvh5wbr.fsf@gitster-ct.c.googlers.com>
On 18/09/19 10:49AM, Junio C Hamano wrote:
> Pratyush Yadav <me@yadavpratyush.com> writes:
>
> > Assuming I have git.git cloned in ../git (relative to git-gui.git), I
> > ran:
> >
> > git pull -Xsubtree=git-gui ../git $branches
> >
> > instead of:
> >
> > git merge $branches
> >
> > because git-gui's tree doesn't have those commits and branches yet, so
> > we can't merge straight away. This seems to have worked, but I thought
> > I'd mention it in case it would cause some subtle problems.
>
> I am not sure what your $branches above are referring to, but if you
The $branches is from Denton's script (its in his email that I replied
to) that lists all the branches merged into git/git-gui that are not in
git-gui. So it should essentially be all the branches not in my tree
that should be.
> run "git log" in the resulting git-gui repository and see any of the
> commits that are about git and not git-gui, then it is not a subtle
> but a grave problem. The reason why git-gui and gitk are separate
> projects is because they do not want to contaminate their history
> with stuff that are not related to them (e.g. changes to "git
> fast-export").
No, I was only pulling in merges related to git-gui into my tree. I do
not intend to pull in any other changes.
> Taking one of the commits Denton found as an example:
>
> >> js/misc-git-gui-stuff: 76756d67061076c046973bff2089ad49f5dc2eb6
>
> (by the way, this can also be found by running
>
> git log --first-parent --min-parents=2 master -- git-gui
Yes, that is what I was doing. Denton's script just made the tedious
task of finding all those out easier.
> in git itself; 02a5f25d956be187bc0 merged it in as its second
> parent. The second parents of these merges you would find are
> candidates---you may already have some, and you may need to merge
> others to your tree; there may be some that are direct updates to
> git-gui/ part of my tree (which shouldn't have been done but
> mistakes happen).
>
> You should be able to merge this (and all other git-gui topics
> already in my tree Denton pointed out) to your 'master'. If you
> then make a trial merge of the result back into my tree with "git
> merge -Xsubtree=git-gui", it should result in "already up to date",
> i.e. a noop merge.
Well, technically it won't be a noop merge because my master has some
changes that haven't been pulled by you yet, but I get the point.
Thanks. I'll test this out.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-09-18 19:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-18 7:02 git-gui: missing some patches from git? Birger Skogeng Pedersen
2019-09-18 9:27 ` Denton Liu
2019-09-18 15:14 ` Pratyush Yadav
2019-09-18 16:56 ` Denton Liu
2019-09-18 17:49 ` Junio C Hamano
2019-09-18 19:22 ` Pratyush Yadav [this message]
2019-09-19 18:32 ` Pratyush Yadav
2019-09-19 18:47 ` Denton Liu
2019-09-19 19:03 ` Pratyush Yadav
2019-09-19 19:11 ` Denton Liu
2019-09-19 19:33 ` Denton Liu
2019-09-24 14:06 ` Pratyush Yadav
2019-09-18 17:31 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190918192222.rqn3oqxfeu7bmnp5@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=birger.sp@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=liu.denton@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).