git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Pratyush Yadav <me@yadavpratyush.com>
To: David <bouncingcats@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes”
Date: Sun, 15 Sep 2019 00:38:32 +0530	[thread overview]
Message-ID: <20190914190656.r2aogh4dcobay5vn@yadavpratyush.com> (raw)
In-Reply-To: <CAMPXz=qWmHGpDrGVpg1gwEBQsg5pujY-Ghg8icyaPoiMNCXssg@mail.gmail.com>

On 15/09/19 02:07AM, David wrote:
> On Sat, 14 Sep 2019 at 06:51, Bert Wesarg <bert.wesarg@googlemail.com> wrote:
> > On Fri, Sep 13, 2019 at 4:32 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
> > > On 13/09/19 12:24PM, Allan Ford wrote:
> >
> > I miss a general problem description: Whats wrong with the
> > single-click on the icon to begin with?
> 
> No problem here, but see my other message for further thoughts.
> 
> > I consider adding a second way as not not acceptable. I also consider
> > double-click on a file in a GUI an "open" action.
> 
> Yes!
> 
> In fact, I've often fantasized how useful it would be that if I double
> clicked on that file name in the unstaged pane or the staged pane,
> then that would open the file for editing in my preferred/configured editor.
> 
> Now for me *that* would be a very frequently used improvement!
> 
> I wonder what other readers think about this idea?

Sounds reasonable. I've wanted something similar, but for commit 
messages.

But one major reason I didn't come up with a patch for editing commit 
messages in the editor of your choice is terminal based editors. I don't 
think there is any way of finding out the default terminal emulator in 
Linux, and I don't think there is a standard way of making terminal 
emulator launch programs you want.

So your suggestion works only for GUI based editors. We would have to 
mention that only GUI based editors can open files.

I like the idea, but I thought I'd point a problem I saw with this 
feature.

Also, the file viewer in git-gui opens the blame viewer, but I suppose 
that's not what most people want.

-- 
Regards,
Pratyush Yadav

  reply	other threads:[~2019-09-14 19:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  2:54 Git Gui - enhancement suggestion - Can a double click on the file name in the “unstaged” area move the item to “staged changes” Allan Ford
2019-09-13 14:32 ` Pratyush Yadav
2019-09-13 20:27   ` Bert Wesarg
2019-09-13 21:06     ` Pratyush Yadav
2019-09-14 16:07     ` David
2019-09-14 19:08       ` Pratyush Yadav [this message]
2019-09-15  3:41         ` David
2019-09-16 17:49           ` Pratyush Yadav
2019-09-13 21:53   ` Marc Branchaud
2019-09-14 15:57     ` David
2019-09-14 21:23       ` Pratyush Yadav
2019-09-15  3:42         ` David
2019-09-14  7:24   ` Johannes Sixt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190914190656.r2aogh4dcobay5vn@yadavpratyush.com \
    --to=me@yadavpratyush.com \
    --cc=bouncingcats@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).