From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on dcvr.yhbt.net X-Spam-Level: X-Spam-ASN: AS31976 209.132.180.0/23 X-Spam-Status: No, score=-4.1 required=3.0 tests=AWL,BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, SPF_HELO_NONE,SPF_NONE shortcircuit=no autolearn=ham autolearn_force=no version=3.4.2 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by dcvr.yhbt.net (Postfix) with ESMTP id 2B0EF1F463 for ; Fri, 13 Sep 2019 14:32:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388667AbfIMOcg (ORCPT ); Fri, 13 Sep 2019 10:32:36 -0400 Received: from relay7-d.mail.gandi.net ([217.70.183.200]:48641 "EHLO relay7-d.mail.gandi.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387600AbfIMOcg (ORCPT ); Fri, 13 Sep 2019 10:32:36 -0400 X-Originating-IP: 157.49.250.150 Received: from localhost (unknown [157.49.250.150]) (Authenticated sender: me@yadavpratyush.com) by relay7-d.mail.gandi.net (Postfix) with ESMTPSA id DD54620004; Fri, 13 Sep 2019 14:32:33 +0000 (UTC) Date: Fri, 13 Sep 2019 20:02:29 +0530 From: Pratyush Yadav To: Allan Ford Cc: git@vger.kernel.org Subject: Re: Git Gui - enhancement suggestion - Can a double =?utf-8?Q?cli?= =?utf-8?Q?ck_on_the_file_name_in_the_=E2=80=9Cunstaged=E2=80=9D_area_move?= =?utf-8?B?IHRoZSBpdGVtIHRvIOKAnHN0YWdlZCBjaGFuZ2Vz4oCd?= Message-ID: <20190913143229.5yop5oaascgavynl@yadavpratyush.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org On 13/09/19 12:24PM, Allan Ford wrote: > Dear Git Authors, > > Not a bug, but a suggestion consideration for “Git Gui” > > Can a double click on the file name in the “unstaged” area move the > item to “staged changes” .. (rather than having to click on the small > icon to the left of the file name?) It has been something on my radar for some time. Shouldn't be something too difficult to do. While I like the idea in general, I have a question that I'd like to ask other git-gui users: If we implement something like this, what happens when you single-click on the icon? Do we treat that as a stage/unstage command? If we keep the legacy behaviour of single-click on the icon stages/unstages, then a part of the row is single-click and the rest double-click. If we make an entire row of the stage/unstage widget double click, it messes with people who are already used to it. Is partial single and partial double click behaviour acceptable? Or should we make the entire row double click only? Or something else that I missed? -- Regards, Pratyush Yadav