From: Denton Liu <liu.denton@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: What's cooking in git.git (Sep 2019, #01; Sat, 7)
Date: Mon, 9 Sep 2019 17:18:58 -0700 [thread overview]
Message-ID: <20190910001858.GA63889@dentonliu-ltm.internal.salesforce.com> (raw)
In-Reply-To: <xmqqo8zti6oy.fsf@gitster-ct.c.googlers.com>
On Mon, Sep 09, 2019 at 12:57:17PM -0700, Junio C Hamano wrote:
> Denton Liu <liu.denton@gmail.com> writes:
>
> > Hi Junio,
> >
> > On Sat, Sep 07, 2019 at 10:26:53AM -0700, Junio C Hamano wrote:
> >> * dl/complete-cherry-pick-revert-skip (2019-08-27) 3 commits
> >> - status: mention --skip for revert and cherry-pick
> >> - completion: add --skip for cherry-pick and revert
> >> - completion: merge options for cherry-pick and revert
> >>
> >> The command line completion support (in contrib/) learned about the
> >> "--skip" option of "git revert" and "git cherry-pick".
> >>
> >> Will merge to 'next'.
> >
> > Did we end up deciding whether or not we were going to drop "status:
> > mention --skip for revert and cherry-pick"?
>
> If you are not convinced it is a good idea, we can easily drop it
> (and I do not mind dropping it---I am not convinced it is a good
> idea myself).
In that case, let's not drop it. The original impetus for this idea came
from cherry-picking a range of commits where one of the commits in the
range patched a file that didn't exist on the target branch, so in this
case skipping was the right course of action.
In any case, I believe that giving the user more information in this
case is, at worst, neutral.
next prev parent reply other threads:[~2019-09-10 0:19 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 17:26 What's cooking in git.git (Sep 2019, #01; Sat, 7) Junio C Hamano
2019-09-09 18:58 ` Denton Liu
2019-09-09 19:57 ` Junio C Hamano
2019-09-10 0:18 ` Denton Liu [this message]
2019-09-09 23:47 ` brian m. carlson
2019-09-10 0:19 ` Junio C Hamano
2019-09-28 23:31 ` Junio C Hamano
2019-09-28 23:35 ` brian m. carlson
2019-09-10 5:04 ` Martin Ågren
2019-09-10 18:23 ` Josh Steadmon
2019-09-11 1:03 ` Matheus Tavares Bernardino
2019-09-11 12:01 ` pd/fetch-jobs, was " Johannes Schindelin
2019-09-12 18:02 ` Junio C Hamano
2019-09-14 13:58 ` Palmer Dabbelt
2019-09-16 17:43 ` Junio C Hamano
2019-09-16 20:40 ` Palmer Dabbelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190910001858.GA63889@dentonliu-ltm.internal.salesforce.com \
--to=liu.denton@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).