On 2019-09-07 at 17:26:53, Junio C Hamano wrote: > * bc/object-id-part17 (2019-08-19) 26 commits > - midx: switch to using the_hash_algo > - builtin/show-index: replace sha1_to_hex > - rerere: replace sha1_to_hex > - builtin/receive-pack: replace sha1_to_hex > - builtin/index-pack: replace sha1_to_hex > - packfile: replace sha1_to_hex > - wt-status: convert struct wt_status to object_id > - cache: remove null_sha1 > - builtin/worktree: switch null_sha1 to null_oid > - builtin/repack: write object IDs of the proper length > - pack-write: use hash_to_hex when writing checksums > - sequencer: convert to use the_hash_algo > - bisect: switch to using the_hash_algo > - sha1-lookup: switch hard-coded constants to the_hash_algo > - config: use the_hash_algo in abbrev comparison > - combine-diff: replace GIT_SHA1_HEXSZ with the_hash_algo > - bundle: switch to use the_hash_algo > - connected: switch GIT_SHA1_HEXSZ to the_hash_algo > - show-index: switch hard-coded constants to the_hash_algo > - blame: remove needless comparison with GIT_SHA1_HEXSZ > - builtin/rev-parse: switch to use the_hash_algo > - builtin/blame: switch uses of GIT_SHA1_HEXSZ to the_hash_algo > - builtin/receive-pack: switch to use the_hash_algo > - fetch-pack: use parse_oid_hex > - patch-id: convert to use the_hash_algo > - builtin/replace: make hash size independent > > Preparation for SHA-256 upgrade continues. > > Looked mostly OK, with a possible update. > cf. <20190820223606.GJ365197@genre.crustytoothpaste.net> Just to update on the status of this, I wasn't planning on a reroll, although I'm happy to do so if folks have feedback. Opinions for or against the current state are welcome. -- brian m. carlson: Houston, Texas, US OpenPGP: https://keybase.io/bk2204