git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: Warren He <pickydaemon@gmail.com>
To: me@ttaylorr.com, gitster@pobox.com, sandals@crustytoothpaste.net
Cc: git@vger.kernel.org, pickydaemon@gmail.com, wh109@yahoo.com
Subject: Re: [PATCH] rebase: introduce --update-branches option
Date: Sat,  7 Sep 2019 16:41:46 -0700	[thread overview]
Message-ID: <20190907234146.1473-1-wh109@yahoo.com> (raw)
In-Reply-To: <20190903013959.GA40029@syl.lan>

Brian, thanks for looking. The only thing I can come up with to say about having
lots of refs is that at least that part of this isn't brand new code. The part
that collects ref info uses the same routines as `git log --decorate`. Do you
recall how long that took in the repository with 80,000 refs?

Junio, thanks for eyeballing. Let me know if some style violations remain.

Taylor, thanks for coming up with a way to configure branches to be excluded. I
haven't worked on implementing that yet. Let's continue to watch for feedback if
people will desire this kind of control.

Using `exec git branch -f` is further discussed in the review, where there are
arguments for introducing a new todo command. I'll add some comments there when
I post a new patch set. But if someone's in favor of accepting a version of this
without that change, with the potential harm from this feature being low enough,
I'm not opposed to that either.

  reply	other threads:[~2019-09-07 23:42 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-02 23:41 [PATCH] rebase: introduce --update-branches option Warren He
2019-09-02 23:41 ` Warren He
2019-09-03 13:26   ` Johannes Schindelin
2019-09-07 23:44     ` [PATCH v2] " Warren He
2019-09-07 23:44       ` Warren He
2019-09-09 10:44       ` Phillip Wood
2019-09-09 14:13         ` Johannes Schindelin
2019-09-09 18:11           ` Junio C Hamano
2019-09-23  9:40           ` Phillip Wood
2019-09-03  0:50 ` [PATCH] " brian m. carlson
2019-09-03  1:21   ` Junio C Hamano
2019-09-03  1:39     ` Taylor Blau
2019-09-07 23:41       ` Warren He [this message]
2019-09-08 18:04         ` brian m. carlson
2019-09-03 12:19 ` Phillip Wood
2019-09-07 23:43   ` Warren He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190907234146.1473-1-wh109@yahoo.com \
    --to=pickydaemon@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    --cc=sandals@crustytoothpaste.net \
    --cc=wh109@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).