From: Taylor Blau <me@ttaylorr.com>
To: Eric Freese <ericdfreese@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH 0/1] for-each-ref: Add '--no-symbolic' option
Date: Sat, 7 Sep 2019 19:16:17 -0400 [thread overview]
Message-ID: <20190907231617.GA36491@syl.local> (raw)
In-Reply-To: <20190907213646.21231-1-ericdfreese@gmail.com>
Hi Eric,
On Sat, Sep 07, 2019 at 03:36:45PM -0600, Eric Freese wrote:
> Hi,
>
> I was recently using git-for-each-ref in a script to get a list of
> remote refs that pointed at a particular commit so that they could
> automatically be updated and pushed back to that remote. This fails when
> it comes across refs/remotes/origin/HEAD, which is a symbolic link.
>
> I was able to solve the problem with:
>
> ```
> git for-each-ref ... --format="%(refname) %(symref)" | grep " $"
> ```
>
> But that feels a little clumsy to me. I would have expected there to be
> a flag like `--no-symbolic` that would exclude symbolic refs from the
> output. So I went ahead and added it :)
Indeed, that does seem a little clumsy to me, too. It's kind of a great
hack, but I could foresee functionality like '--no-symbolic' to be
useful to avoid hackery like this.
> I could forsee this option also being added to git-branch and git-tag,
> but decided to keep it to git-for-each-ref to test the waters before
> investing any further time into it.
Yep. It's good that your patches are mainly in the 'ref-filter.[ch]'
code, so it would be easy to wire up new flags in both the branch+tag
builtins, too, since they use the same ref-filter API.
> Cheers
>
> Eric Freese (1):
> for-each-ref: add '--no-symbolic' option
>
> Documentation/git-for-each-ref.txt | 3 +++
> builtin/for-each-ref.c | 4 +++-
> ref-filter.c | 4 ++++
> ref-filter.h | 3 ++-
> t/t6302-for-each-ref-filter.sh | 6 ++++++
> 5 files changed, 18 insertions(+), 2 deletions(-)
>
> --
> 2.23.0
Thanks,
Taylor
prev parent reply other threads:[~2019-09-07 23:16 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-07 21:36 [RFC PATCH 0/1] for-each-ref: Add '--no-symbolic' option Eric Freese
2019-09-07 21:36 ` [RFC PATCH 1/1] for-each-ref: add " Eric Freese
2019-09-07 23:28 ` Taylor Blau
2019-09-07 23:39 ` Taylor Blau
2019-09-08 9:44 ` Jeff King
2019-09-07 23:37 ` Taylor Blau
2019-09-08 10:05 ` Jeff King
2019-09-08 15:40 ` Junio C Hamano
2019-09-08 22:34 ` Junio C Hamano
2019-09-09 4:01 ` Eric Freese
2019-09-09 12:57 ` Jeff King
2019-09-09 18:08 ` Junio C Hamano
2019-09-07 23:16 ` Taylor Blau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190907231617.GA36491@syl.local \
--to=me@ttaylorr.com \
--cc=ericdfreese@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).