git@vger.kernel.org mailing list mirror (one of many)
 help / color / mirror / code / Atom feed
From: "SZEDER Gábor" <szeder.dev@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Johannes Schindelin <johannes.schindelin@gmx.de>,
	Luke Diamand <luke@diamand.org>,
	Lars Schneider <larsxschneider@gmail.com>,
	git@vger.kernel.org
Subject: Re: [PATCH] ci: install P4 from package to fix build error
Date: Fri, 6 Sep 2019 12:58:25 +0200	[thread overview]
Message-ID: <20190906105825.GD32087@szeder.dev> (raw)
In-Reply-To: <20190906102711.6401-1-szeder.dev@gmail.com>

On Fri, Sep 06, 2019 at 12:27:11PM +0200, SZEDER Gábor wrote:
> To test 'git-p4' in the Linux Clang and GCC build jobs we used to
> install the 'p4' and 'p4d' binaries by directly downloading those
> binaries from a Perforce filehost.  This has worked just fine ever
> since we started using Travis CI [1], but during the last day or so
> that filehost appeared to be gone: while its hostname still resolves,
> the host doesn't seem to reply to any download request, it doesn't
> even refuse the connection, and eventually our build jobs time out
> [2].
> 
> Now, this might be just a temporary glitch, but I'm afraid that it
> isn't.

Well, now would you believe it, while I was testing this patch (I even
made a gitgitgadget PR to run it on Azure Pipelines! :) and touching
up its log message the good old Perforce filehost sprang back to life,
and the CI build jobs now succeed again even without this patch.

> Let's install P4 from the package repository, because this approach
> seems to be simpler and more future proof.
> 
> Note that we used to install an old P4 version (2016.2) in the Linux
> build jobs, but with this change we'll install the most recent version
> available in the Perforce package repository (currently 2019.1).

So I'm not quite sure whether we really want this patch.  It depends
on how important it is to test 'git-p4' with an old P4 version, but I
don't really have an opinion on that.


  reply	other threads:[~2019-09-06 10:58 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 10:27 [PATCH] ci: install P4 from package to fix build error SZEDER Gábor
2019-09-06 10:58 ` SZEDER Gábor [this message]
2019-09-09 22:51   ` Johannes Schindelin
2019-09-10 12:24     ` SZEDER Gábor
2019-09-11 15:12       ` Johannes Schindelin
2019-09-12 11:09         ` SZEDER Gábor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: http://vger.kernel.org/majordomo-info.html

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190906105825.GD32087@szeder.dev \
    --to=szeder.dev@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=johannes.schindelin@gmx.de \
    --cc=larsxschneider@gmail.com \
    --cc=luke@diamand.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://80x24.org/mirrors/git.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).