From: Jeff King <peff@peff.net>
To: "René Scharfe" <l.s.r@web.de>
Cc: Git Mailing List <git@vger.kernel.org>,
Junio C Hamano <gitster@pobox.com>,
Stefan Sperling <stsp@stsp.name>
Subject: Re: [PATCH 1/2] tag: factor out get_tagged_oid()
Date: Fri, 6 Sep 2019 03:13:21 -0400 [thread overview]
Message-ID: <20190906071320.GA14343@sigill.intra.peff.net> (raw)
In-Reply-To: <1385c954-d9ef-7ef6-6185-0dad885531ec@web.de>
On Thu, Sep 05, 2019 at 09:55:55PM +0200, René Scharfe wrote:
> Add a function for accessing the ID of the object referenced by a tag
> safely, i.e. without causing a segfault when encountering a broken tag
> where ->tagged is NULL.
This approach seems to pretty reasonable. As somebody who's been
thinking about this, I'd be curious to hear your thoughts on:
https://public-inbox.org/git/20190906065606.GC5122@sigill.intra.peff.net/
which _in theory_ means tag->tagged would never be NULL (we'd catch it
at the parsing stage and consider that an error). But we'd still
potentially want to protect ourselves as you do here for code paths
which don't necessarily check the parse result.
-Peff
next prev parent reply other threads:[~2019-09-06 7:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-05 19:55 [PATCH 1/2] tag: factor out get_tagged_oid() René Scharfe
2019-09-05 19:59 ` [PATCH 2/2] use get_tagged_oid() René Scharfe
2019-09-06 7:13 ` Jeff King [this message]
2019-09-06 15:05 ` [PATCH 1/2] tag: factor out get_tagged_oid() René Scharfe
2019-09-06 15:25 ` René Scharfe
2019-09-06 17:51 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190906071320.GA14343@sigill.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=l.s.r@web.de \
--cc=stsp@stsp.name \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).