From: Pratyush Yadav <me@yadavpratyush.com>
To: Birger Skogeng Pedersen <birger.sp@gmail.com>
Cc: Bert Wesarg <bert.wesarg@googlemail.com>,
Git List <git@vger.kernel.org>,
bouncingcats@gmail.com
Subject: Re: feature request, git-gui: add hotkey to toggle amend/new
Date: Tue, 3 Sep 2019 23:04:18 +0530 [thread overview]
Message-ID: <20190903173418.32hqxfzr7wajtikx@yadavpratyush.com> (raw)
In-Reply-To: <CAGr--=JaTvZ_mUK5+dW6eM3-71ROUR4c58TF9G=-jAw3GDzYTQ@mail.gmail.com>
On 03/09/19 04:06PM, Birger Skogeng Pedersen wrote:
> Hi Pratyush,
>
>
> On Tue, Sep 3, 2019 at 2:45 PM Pratyush Yadav <me@yadavpratyush.com> wrote:
> > Can you try doing a Shift+Tab? For me on Linux, if I hit Shift+Tab, it
> > immediately takes me to the "Amend last commit" option. Then I can press
> > space to select it and Tab again to get back to the commit message.
>
> It seems that Shift+Tab doesn't do anything (on Windows 10).
Ah, too bad.
> Regardless, imo there should be a binding dedicated to toggle amend.
>
> > Also, since we are on this topic, how about making the "Amend last
> > commit" button a toggle instead? This would act as a "turn amend mode
> > on/off" button. Since "Amend last commit" and "New Commit" are mutually
> > exclusive, a single toggle to switch between those modes makes sense to
> > me.
>
> I assume you're talking about the button in the "Commit" dropdown
Yes. That one and the two tick boxes on the top right of the commit
message buffer/editor.
> menu. I agree, it could be just a single entry which is a toggle to
> enable/disable amending. And (above the commit message dialog) perhaps
> just a single checkbox; "Amend Last Commit". In other git GUIs (Git
> Cola and TortoiseGit) I see they're using just a single checkbox for
> this option. But maybe that is a slightly different topic, the hotkey
> behaviour would remain the same.
Yes, of course your patch is independent of the two-button behaviour. I
was just pointing it out to see how others feel about it.
>
>
> > ... do you still feel the need for a dedicated binding for amends?
>
> How do you guys feel about it? So far it seems we're at two "yay" and
> one "nay". I really feel it is in the best interest of the git-gui
> project to implement this hotkey. And not just because it is my
> personal preference to have it :-)
Well, I do think amending commits is a common enough operation to
warrant a dedicated keyboard binding for it. So it is a "yay" for this
feature from my side at least.
--
Regards,
Pratyush Yadav
next prev parent reply other threads:[~2019-09-03 17:34 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-31 10:51 feature request, git-gui: add hotkey to toggle amend/new Birger Skogeng Pedersen
2019-09-02 16:25 ` Birger Skogeng Pedersen
2019-09-02 18:07 ` Bert Wesarg
2019-09-02 19:49 ` Birger Skogeng Pedersen
2019-09-02 19:56 ` [PATCH] Add hotkey to toggle "Amend Last Commit" radio selector Birger Skogeng Pedersen
2019-09-03 8:52 ` Bert Wesarg
2019-09-03 10:25 ` Bert Wesarg
2019-09-03 16:20 ` Bert Wesarg
2019-09-02 20:12 ` feature request, git-gui: add hotkey to toggle amend/new Bert Wesarg
2019-09-02 20:15 ` Bert Wesarg
2019-09-03 5:37 ` Birger Skogeng Pedersen
2019-09-03 12:45 ` Pratyush Yadav
2019-09-03 14:06 ` Birger Skogeng Pedersen
2019-09-03 17:34 ` Pratyush Yadav [this message]
2019-09-03 15:35 ` David
2019-09-03 17:27 ` Pratyush Yadav
2019-09-04 6:24 ` Johannes Sixt
2019-09-04 17:46 ` Pratyush Yadav
2019-09-04 17:54 ` Birger Skogeng Pedersen
2019-09-04 18:52 ` Johannes Sixt
2019-09-04 19:03 ` Bert Wesarg
2019-09-10 8:54 ` David Aguilar
2019-09-11 10:27 ` Birger Skogeng Pedersen
2019-09-11 18:34 ` Pratyush Yadav
2019-09-11 18:47 ` Pratyush Yadav
2019-09-03 1:01 ` David
2019-09-03 8:44 ` Bert Wesarg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: http://vger.kernel.org/majordomo-info.html
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190903173418.32hqxfzr7wajtikx@yadavpratyush.com \
--to=me@yadavpratyush.com \
--cc=bert.wesarg@googlemail.com \
--cc=birger.sp@gmail.com \
--cc=bouncingcats@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://80x24.org/mirrors/git.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).